Skip to content

removeDefinition fix for removing first added one #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomasVotruba wants to merge 1 commit into from
Closed

removeDefinition fix for removing first added one #72

TomasVotruba wants to merge 1 commit into from

Conversation

@TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Jun 9, 2015

One more related bug to #71:

$someInterface => [
    0 => FirstService
    1 => SecondService
];

Remove 'FirstService':

$someInterface => [
    1 => SecondService
];

Then, getByType will try to get [0] => FAIL

Solution? Something like:

return reset($this->classes[$class][TRUE]);

What do you think?

@dg dg force-pushed the master branch 5 times, most recently from 912f91c to 94f96ad Compare June 10, 2015 11:52
@dg dg closed this in 58ed2d8 Jun 17, 2015
dg added a commit that referenced this pull request Jun 17, 2015
@dg
ContainerBuilder::removeDefinition() fixed keys in $classes [Closes #72]
d73146d
dg added a commit that referenced this pull request Jun 17, 2015
@dg
ContainerBuilder::removeDefinition() fixed keys in $classes [Closes #72]
d690c94
@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Jun 17, 2015

👍

@TomasVotruba TomasVotruba deleted the container-builder-remove-definition-fix branch June 17, 2015 21:58
@MartinSadovy MartinSadovy mentioned this pull request Feb 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TomasVotruba