Skip to content

Compiler: definition of 'type' will not overide 'factory' of parent service #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 1 commit into from
Mar 13, 2019
Merged

Compiler: definition of 'type' will not overide 'factory' of parent service #39

dg merged 1 commit into from
Mar 13, 2019

Conversation

@dg
Copy link
Member

@dg dg commented Jan 22, 2015 •
edited
Loading 

services:
     router: 
          type: class

will not override parent factory

@dg dg force-pushed the pull-overide branch 2 times, most recently from 0005ffe to 3eee1f1 Compare February 3, 2015 14:53
@dg dg force-pushed the pull-overide branch 2 times, most recently from da728f2 to 6eb0b44 Compare February 10, 2015 04:02
@dg dg mentioned this pull request Feb 16, 2015
Closed
@dg dg force-pushed the master branch 4 times, most recently from 335376f to 3700c2c Compare February 18, 2015 16:33
@dg dg force-pushed the pull-overide branch from ee520bd to 77fba68 Compare May 25, 2015 13:25
@dg dg force-pushed the master branch 5 times, most recently from 912f91c to 94f96ad Compare June 10, 2015 11:52
@dg dg force-pushed the master branch 3 times, most recently from 2d6ac3c to 1d7d277 Compare June 19, 2015 11:58
@dg dg force-pushed the master branch 12 times, most recently from 94983e4 to cfa4077 Compare March 5, 2019 05:18
@dg dg force-pushed the master branch 5 times, most recently from f96d97d to db0bc17 Compare March 13, 2019 02:33
@dg dg changed the title Compiler: definition of 'factory' will not overide 'class' of parent service [WIP] Compiler: definition of 'type' will not overide 'factory' of parent service Mar 13, 2019
@dg dg merged commit 1c87ed0 into nette:master Mar 13, 2019
@dg dg deleted the pull-overide branch March 13, 2019 14:19
dg added a commit that referenced this pull request Mar 13, 2019
@dg
Processor: definition of 'type' will not overide 'factory' of parent …
8d79d8c 
…service (BC break) (#39)
dg added a commit that referenced this pull request Mar 14, 2019
@dg
Processor: definition of 'type' will not overide 'factory' of parent …
fafd328 
…service (BC break) (#39)
dg added a commit that referenced this pull request Mar 17, 2019
@dg
Processor: definition of 'type' will not overide 'factory' of parent …
2a27d80 
…service (BC break) (#39)
dg added a commit that referenced this pull request Mar 22, 2019
@dg
Processor: definition of 'type' will not overide 'factory' of parent …
1adcd1c 
…service (BC break) (#39)
dg added a commit that referenced this pull request Mar 22, 2019
@dg
Processor: definition of 'type' will not override 'factory' of parent…
18fdc11 
… service (#39)

for BC compatibility, 'class' will override 'factory'
dg added a commit that referenced this pull request Mar 25, 2019
@dg
Processor: option 'type' will not override 'factory' of parent service (
0a0d880 
#39)

for BC compatibility, 'class' will override 'factory'
dg added a commit to dg/nette-di that referenced this pull request Mar 25, 2019
@dg
Processor: option 'type' will not override 'factory' of parent service (
fcdb0d3 
nette#39)

for BC compatibility, 'class' will override 'factory'
dg added a commit that referenced this pull request Apr 2, 2019
@dg
Processor: option 'type' will not override 'factory' of parent service (
cfccb4d 
#39)

for BC compatibility, 'class' will override 'factory', except class in imported services [Closes phpstan/phpstan#2033]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dg @TomasVotruba