Route::constructUrl(): split of module and presenter moved before global filter #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Makes sense, thanks. |
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 3, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 3, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 3, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 3, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some changes in structure of my application and I have found something what is IMHO bug.
In short: right now, the global input filter gets module and presenter split (like this: [Module: 'Front', Presenter: 'Homepage']) but output filter gets them together as presenter ([Presenter: 'Front:Homepage']).
Wouldn't it be better to unify the behaviour of those two functions to get the params split in both cases?