Skip to content

Conversation

@lukascellar
Copy link

Variable $since at line 1172 is undefined and causes PHP Notice.

Variable $since at line 1172 is undefined and causes PHP Notice.
@dg
Copy link
Member

dg commented Dec 1, 2016

This should never happen (line 1164). What's your structure components?

@dg dg force-pushed the master branch 4 times, most recently from 7447ad4 to 3165d3a Compare December 22, 2016 18:28
@dg dg force-pushed the master branch 4 times, most recently from 3fb5d4a to d2e3dc1 Compare January 9, 2017 19:54
@dg dg force-pushed the master branch 11 times, most recently from 07d4ebb to 337c67c Compare January 19, 2017 13:27
@dg dg force-pushed the master branch 9 times, most recently from 7c8af57 to ec7d92a Compare January 25, 2017 21:30
@TomasVotruba
Copy link

TomasVotruba commented Apr 12, 2017

@lukascellar Could you provide more details?

@lukascellar
Copy link
Author

It occurs in dashboard of my application, some dashboard controls are registered dynamically in DI extension (modular application, module can add component to dashboard).

/admin?dashboard-todoControl-todoGrid-id=472&do=dashboard-todoControl-todoGrid-solve

	public function beforeCompile()
	{
		$builder = $this->getContainerBuilder();

		/**
		 * Install to dashboard
		 */
		foreach ($builder->findByType(DashboardPresenter::class) as $dashboardPresenterDefinition) {
			$dashboardPresenterDefinition
				->addSetup(new Statement('$service->getComponent(\'dashboard\')->addComponent(?, ?)', [
					new Statement('@' . $this->prefix('todoControlFactory') . '::create'),
					'todoControl'
				]))
				->addSetup('$service->getComponent(\'dashboard\')->getComponent(\'todoControl\')->addFilterHideSolved(?)', [true]);
		}
	}

@dg dg closed this in 66cd441 Apr 12, 2017
dg added a commit that referenced this pull request Apr 12, 2017
@TomasVotruba
Copy link

TomasVotruba commented Apr 12, 2017

Thank you Lukáši for nice report.

And you Davide for fast fixup!

@dg
Copy link
Member

dg commented Apr 12, 2017

@lukascellar lukascellar deleted the patch-1 branch April 12, 2017 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants