feat(catalan-translation): catalan translation added#3412
Merged
erezrokah merged 5 commits intodecaporg:masterfrom Mar 13, 2020
Merged
feat(catalan-translation): catalan translation added#3412erezrokah merged 5 commits intodecaporg:masterfrom
erezrokah merged 5 commits intodecaporg:masterfrom
Conversation
Contributor
|
Nice work! Compared to the English locale, it seems there are a couple of translations missing. Would you mind adding those? |
Contributor
Author
|
Hi @tomrutgers. I've updated the PR by adding the missing keys. Thanks for the advice. |
Contributor
|
Excellent! Also try to run |
Contributor
Author
|
Yes, I've realized that there was a format issue after 2 commits. The PR with all test completed using |
erezrokah
reviewed
Mar 13, 2020
erezrokah
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and summary
I dived into your amazing CMS lately and I found out that it currently doesn't offer Catalan, my native language.
This PR fixes the issue by adding a Catalan translation for the netlify-cms-locales package.
I know that it's a minor contribution but I'd love to contribute to this amazing project and make it reach even more people.
I hope to keep adding features as soon as my schedule allows me.
Test plan
As mentioned in my previous PR #3409, I won't add any coverage tests. However, I made sure that the current tests work appropriately, as shown in the following screenshot:
Cute pic requirement complied with.