Skip to content

Feat/catalan translation#3409

Closed
fbuireu wants to merge 6 commits intodecaporg:masterfrom
fbuireu:feat/catalan-translation
Closed

Feat/catalan translation#3409
fbuireu wants to merge 6 commits intodecaporg:masterfrom
fbuireu:feat/catalan-translation

Conversation

@fbuireu
Copy link
Contributor

@fbuireu fbuireu commented Mar 12, 2020

Motivation and summary
I dived into your amazing CMS lately and I found out that it currently doesn't offer Catalan, my native language.
This PR fixes the issue by adding a Catalan translation for the netlify-cms-locales package.

I know that it's a minor contribution but I'd love to contribute to this amazing project and make it reach even more people.

I hope to keep adding features as soon as my schedule allows me.

Test plan
I've added the option of Catalan language translation to all current Mocha tests, here's the screenshot of coverage:

image

A picture of a cute animal (not mandatory but encouraged)

Cute pic requirement complied with.

image

@fbuireu fbuireu requested a review from a team March 12, 2020 08:39
@erezrokah
Copy link
Contributor

Thanks @fbuireu, there seems to be a lot of unrelated changes in this PR.
Do you mind opening a new one just for the translation file (and the default export from index.js)?
Also, those tests for getFieldsNames are not language specific, they demonstrate accessing nested fields via dot notation. We use languages in the tests since it is a common use case for that.
In short, adding cat to those tests might not be required.

@erezrokah
Copy link
Contributor

Replaced by #3412

@erezrokah erezrokah closed this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants