Fixes and improves the installer/updater shell scripts.#7847
Merged
prologic merged 7 commits intonetdata:masterfrom Jan 27, 2020
prologic:improve_shell_scripts
Merged
Fixes and improves the installer/updater shell scripts.#7847prologic merged 7 commits intonetdata:masterfrom prologic:improve_shell_scripts
prologic merged 7 commits intonetdata:masterfrom
prologic:improve_shell_scripts
Conversation
Manage this branch in SquashTest this branch here: https://prologicimprove-shell-scripts-xo9wi.squash.io |
knatsakis
suggested changes
Jan 24, 2020
Member
|
Agreed with @knatsakis's comments. Also, as usual, the hashes in the documentation files need to be updated. |
Contributor
Author
I sweat to god we should automate this :) |
Co-Authored-By: Konstantinos Natsakis <5933427+knatsakis@users.noreply.github.com>
Co-Authored-By: Konstantinos Natsakis <5933427+knatsakis@users.noreply.github.com>
Co-Authored-By: Konstantinos Natsakis <5933427+knatsakis@users.noreply.github.com>
prologic
commented
Jan 25, 2020
Contributor
Author
prologic
left a comment
There was a problem hiding this comment.
Reviewed/Fixed my own bad conflict resolution :)
knatsakis
approved these changes
Jan 25, 2020
Ferroin
approved these changes
Jan 27, 2020
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
* Auto-formatted the installer/updater shell scripts * Fixed shellcheck problems founds for installer/updater shell scripts * Update netdata-installer.sh Co-Authored-By: Konstantinos Natsakis <5933427+knatsakis@users.noreply.github.com> * Update packaging/installer/kickstart-static64.sh Co-Authored-By: Konstantinos Natsakis <5933427+knatsakis@users.noreply.github.com> * Update packaging/makeself/install-or-update.sh Co-Authored-By: Konstantinos Natsakis <5933427+knatsakis@users.noreply.github.com> * Updated md5sum of kickstart-static64.sh in docs * Fixed bad rebase/merge conflicts Co-authored-by: Konstantinos Natsakis <5933427+knatsakis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failures in #7846
Component Name
area/packaging
Additional Information