Add anon tracking notice for installers#7437
Merged
Ferroin merged 4 commits intonetdata:masterfrom Dec 19, 2019
Merged
Conversation
Manage this branch in SquashTest this branch here: https://ncmansadd-anon-tracking-notice-i5h5a.squash.io |
|
You should be checking for DO_NOT_TRACK as non-zero and non-empty, not specifically equal to 1. Additionally, the claim that the statistics being collected are anonymous is false. |
Contributor
|
Hey @ncmans, check this: Homebrew/brew#6745 🤔 |
cakrit
reviewed
Dec 6, 2019
Member
|
Also Fixes:#7470 Somehow the docs got updated to mention the option before this got merged. |
Contributor
|
Hey @Ferroin — Where do you see the docs updated? All I'm aware of is the my PR that's still open, unless someone managed to sneak some changes to the docs past me completely... |
Member
|
@joelhans On the live docs site, anonymous statistics page, all the way at the bottom it mentions the |
Ferroin
approved these changes
Dec 16, 2019
cosmix
approved these changes
Dec 19, 2019
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
* Show notice of anonymous data collection * Add DO_NOT_TRACK env var to docker run script * Add disable-telemetry option to kickstart-static64 * Check if DO_NOT_TRACK is set
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
* Show notice of anonymous data collection * Add DO_NOT_TRACK env var to docker run script * Add disable-telemetry option to kickstart-static64 * Check if DO_NOT_TRACK is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7401
Fixes #7470
TODO