Feature/99 yaml config all cmd options #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Dec 10, 2021
added 4 commits
December 9, 2021 18:06
- Add CmdOption struct with possible cmd option to pkvisor main file
- Check config file and args before validating and executing each option
- Prioritize cmd options over config file
weyrick
requested changes
Dec 10, 2021
Contributor
weyrick
left a comment
There was a problem hiding this comment.
Looks good, only one request: the rest of the YAML config files use underscores instead of dashes, so please change the config file version of the options to use underscore, e.g. "log_file" instead of "log-file"
weyrick
approved these changes
Dec 10, 2021
weyrick
added a commit
that referenced
this pull request
Dec 27, 2021
weyrick
added a commit
that referenced
this pull request
Dec 27, 2021
fix a few typos introduced in PR #159
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.