Skip to content

Get the CI running again#260

Merged
jstasiak merged 2 commits intomasterfrom
fix-ci
Sep 14, 2023
Merged

Get the CI running again#260
jstasiak merged 2 commits intomasterfrom
fix-ci

Conversation

@jstasiak
Copy link
Contributor

It's currently failing because:

  • Python 2.7 is no longer supported[1]
  • setup-python v2 can't find PyPy3.6 on Mac, I think upgrading to v4 will help

Upgrading setup-python to v4 requires us to change how to refer to PyPy – we have to specify the actual version now.

[1] actions/setup-python#672

It's currently failing because:

* Python 2.7 is no longer supported[1]
* setup-python v2 can't find PyPy3.6 on Mac, I think upgrading to v4
  will help

Upgrading setup-python to v4 requires us to change how to refer to PyPy
– we have to specify the actual version now.

[1] actions/setup-python#672
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.45% ⚠️

Comparison is base (b6c4203) 86.76% compared to head (378ff07) 85.32%.
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   86.76%   85.32%   -1.45%     
==========================================
  Files          48       48              
  Lines        4565     4566       +1     
  Branches      659      706      +47     
==========================================
- Hits         3961     3896      -65     
- Misses        424      488      +64     
- Partials      180      182       +2     
Files Changed Coverage Δ
netaddr/core.py 68.49% <100.00%> (ø)
netaddr/tests/ip/test_ip_ranges.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstasiak jstasiak merged commit 66ccbe1 into master Sep 14, 2023
@jstasiak jstasiak deleted the fix-ci branch September 14, 2023 22:22
jstasiak added a commit that referenced this pull request Sep 14, 2023
When you go to [1] for example you'll see we have twice as many CI jobs
compared to what we expect (36 instead of 18).

Let's only run "push" jobs on master.

[1] #260
jstasiak added a commit that referenced this pull request Sep 14, 2023
When you go to [1] for example you'll see we have twice as many CI jobs
compared to what we expect (36 instead of 18).

Let's only run "push" jobs on master.

[1] #260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants