fix: missing ApiProperty enum undefined on array handling#3590
Merged
kamilmysliwiec merged 2 commits intonestjs:masterfrom Oct 16, 2025
Merged
Conversation
…dling
Fixes issue where an undefined enum option property incorrectly results in array items changed to `{type: 'number', enum: []}`.
Adds test to check for correct schema when undefined enum on array property is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using
enum: undefinedon an array property:the resulting schema incorrectly becomes:
{ "testStringArray": { "type": "array", "items": { "type": "number", "enum": [] } } }This is similar to the bug fixed in #3232, but was not fixed for the case where the property is an array.
Issue Number: N/A
What is the new behavior?
After this fix the resulting schema correctly becomes:
{ "testStringArray": { "type": "array", "items": { "type": "string" } } }Does this PR introduce a breaking change?
Other information