Skip to content

fix: missing ApiProperty enum undefined handling#3232

Merged
kamilmysliwiec merged 2 commits intonestjs:masterfrom
nxht:fix/3229
Jan 10, 2025
Merged

fix: missing ApiProperty enum undefined handling#3232
kamilmysliwiec merged 2 commits intonestjs:masterfrom
nxht:fix/3229

Conversation

@nxht
Copy link
Copy Markdown
Contributor

@nxht nxht commented Jan 10, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #3229

What is the new behavior?

@ApiProperty({enum: undefined}) doesn't modify type

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 8c9cd39 into nestjs:master Jan 10, 2025
@kamilmysliwiec
Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants