RFC(0043): CKB softfork activation#349
Conversation
janx
left a comment
There was a problem hiding this comment.
An epoch in CKB (4 hours) is far shorter than an epoch in BItcoin (2 weeks). The tally period of softfork signaling should be long enough so it's resistant to governance attack. Instead of 1 epoch (4 hours), I think CKB softfork activation tally period should be at least as long as Bitcoin's (2 weeks ~= 90 CKB epochs).
rfcs/0000-ckb-softfork-activation/0000-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-ckb-softfork-activation/0000-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-ckb-softfork-activation/0000-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-ckb-softfork-activation/0000-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-ckb-softfork-activation/0000-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-ckb-softfork-activation/0000-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-ckb-softfork-activation/0000-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-ckb-softfork-activation/0000-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
I'm not so sure it's appropriate to measure the replacement in realistic time, CKB is much faster to mine, 2 weeks ~= 151,200 blocks. |
|
Despite its similarities with BIP9, I would still like the following information to be added to the RFC so that it is more friendly to readers like me.
I agree with Jan that deciding on a soft fork upgrade with a four-hour epoch seems too short. Perhaps it's better to define a longer time-unit like "era" (90 epochs each) and make decisions based on eras. Personally, I think a month or two is enough to make decisions. So we can set the parameters so that as soon as all miners are on board, the soft fork is activated in a month. |
Why is |
Optimistically, we hope that BIP8 will not be used,
|
fbcbbcb to
335f9ca
Compare
|
The current signaling period is tentatively set at 42 epochs, approximately one week. |
335f9ca to
36b0e0a
Compare
36b0e0a to
56def0e
Compare
rfcs/0043-ckb-softfork-activation/0043-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
7c0229c to
21b7bc0
Compare
21b7bc0 to
d7fc2c0
Compare
3631: feat: add light client support to ckb full node r=zhangsoledad a=quake ### What problem does this PR solve? add light client support to ckb full node ### What is changed and how it works? related rfcs: [RFC(0043): CKB softfork activation](nervosnetwork/rfcs#349) [RFC: CKB Light Client Protocol](nervosnetwork/rfcs#370) [RFC: Client Side Block Filter Protocol](nervosnetwork/rfcs#375) ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note Note: Add a note under the PR title in the release note. ``` Co-authored-by: Boyu Yang <yangby@cryptape.com> Co-authored-by: quake <quake.wang@gmail.com> Co-authored-by: Linfeng Qian <thewawar@gmail.com> Co-authored-by: Quake Wang <quake.wang@gmail.com>
rfcs/0043-ckb-softfork-activation/0043-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0043-ckb-softfork-activation/0043-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0043-ckb-softfork-activation/0043-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0043-ckb-softfork-activation/0043-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0043-ckb-softfork-activation/0043-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0043-ckb-softfork-activation/0043-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
rfcs/0043-ckb-softfork-activation/0043-ckb-softfork-activation.md
Outdated
Show resolved
Hide resolved
a70db7a to
7864968
Compare
Co-authored-by: ian <me@iany.me>
7864968 to
ec4e198
Compare
3652: chore: tweak softfork activation params r=zhangsoledad a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What is changed and how it works? Tweak parameters according to the latest changes of rfcs nervosnetwork/rfcs#349 ### Related changes - PR to update `owner/repo`: - Need to cherry-pick to the release branch ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` Co-authored-by: zhangsoledad <787953403@qq.com>
3652: chore: tweak softfork activation params r=zhangsoledad a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What is changed and how it works? Tweak parameters according to the latest changes of rfcs nervosnetwork/rfcs#349 ### Related changes - PR to update `owner/repo`: - Need to cherry-pick to the release branch ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` Co-authored-by: zhangsoledad <787953403@qq.com>
Preview Link
This is a proposal based on BIP9 modified by ckb characteristics and also incorporates the "speedy trial" activation specification.