Skip to content

fix(ast_grep): csharp -> cs. Correct filetype for ast_grep csharp files#4253

Merged
justinmk merged 2 commits intoneovim:masterfrom
CharlesTaylor7:ast-grep/cs
Dec 22, 2025
Merged

fix(ast_grep): csharp -> cs. Correct filetype for ast_grep csharp files#4253
justinmk merged 2 commits intoneovim:masterfrom
CharlesTaylor7:ast-grep/cs

Conversation

@CharlesTaylor7
Copy link
Contributor

@CharlesTaylor7 CharlesTaylor7 commented Dec 21, 2025

Problem

csharp is not a valid filetype in neovim. csharp files are of filetype cs.

You can see a warning by doing

vim.ls.enable({ "ast_grep"})

:checkheatlh lsp or :LspInfo shows this warning:

vim.lsp: Enabled Configurations
⚠️  WARNING Unknown filetype 'csharp' (Hint: filename extension != filetype).

@CharlesTaylor7 CharlesTaylor7 changed the title fix: csharp -> cs. Correct filetype for ast_grep csharp files fix(ast_grep): csharp -> cs. Correct filetype for ast_grep csharp files Dec 21, 2025
@CharlesTaylor7
Copy link
Contributor Author

CharlesTaylor7 commented Dec 21, 2025

On a related note there are warnings for javascript.jsx and typescript.tsx.

 ⚠️  WARNING Unknown filetype 'javascript.jsx' (Hint: filename extension != filetype).
 ⚠️  WARNING Unknown filetype 'typescript.tsx' (Hint: filename extension != filetype).

Given javascriptreact and typescriptreact are also defined here, I am wondering what's going on.

Is this for some sort of backwards compatibility?

@CharlesTaylor7
Copy link
Contributor Author

Best I can tell, vim/neovim has never used javascript.jsx nor typescript.tsx as filetypes.
vim/vim@92852ce

@justinmk justinmk merged commit 32055d7 into neovim:master Dec 22, 2025
5 checks passed
ValdezFOmar added a commit to ValdezFOmar/nvim-lspconfig that referenced this pull request Feb 26, 2026
Problem:

When enabling configs with these filetypes, `checkhealth vim.lsp`
reports the following warnings for each config:
- ⚠️ WARNING Unknown filetype 'javascript.jsx'.
- ⚠️ WARNING Unknown filetype 'typescript.tsx'.

Solution:

Remove them (neovim#4253, neovim#4299).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants