feat(lsp): support auto-force escalation in client stop#36378
Merged
MariaSolOs merged 1 commit intoneovim:masterfrom Nov 2, 2025
Merged
feat(lsp): support auto-force escalation in client stop#36378MariaSolOs merged 1 commit intoneovim:masterfrom
MariaSolOs merged 1 commit intoneovim:masterfrom
Conversation
MariaSolOs
commented
Oct 29, 2025
MariaSolOs
commented
Oct 29, 2025
| end | ||
| end | ||
| for _, client in pairs(active_clients) do | ||
| client:stop(client.flags.exit_timeout) |
Member
Author
There was a problem hiding this comment.
I might be missing something but this should preserve the current behavior: exit_timeout is false by default, and then we don't need to have the custom timeout tracking here as if exit_timeout is a number then auto-escalation will happen.
c4818cc to
520fbd1
Compare
520fbd1 to
880576f
Compare
mfussenegger
approved these changes
Nov 1, 2025
MariaSolOs
added a commit
to MariaSolOs/neovim
that referenced
this pull request
Nov 2, 2025
(cherry picked from commit 02cd564)
This was referenced Nov 3, 2025
This was referenced Dec 2, 2025
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Dec 2, 2025
This fixes most of the delays caused by neovim#36750. The delays caused by neovim#36378 still seem to remain.
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Dec 2, 2025
This fixes most of the delays caused by neovim#36750. The delays caused by neovim#36378 still seem to remain.
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Dec 2, 2025
Also, don't start the timer at all when a previous shutdown failed, as in this case a forced shutdown is used and no timer is needed. This fixes most of the delays caused by neovim#36750. The delays caused by neovim#36378 still seem to remain.
zeertzjq
added a commit
that referenced
this pull request
Dec 2, 2025
yochem
pushed a commit
to yochem/neovim
that referenced
this pull request
Dec 15, 2025
Also, don't start the timer at all when a previous shutdown failed, as in this case a forced shutdown is used and no timer is needed. This fixes most of the delays caused by neovim#36750. The delays caused by neovim#36378 still seem to remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #28479