Merged
Conversation
Member
|
We do not have generics for |
Contributor
Author
|
@Technici4n You will notice that it did compile (yes, yes, license violation...) with FML head, so I think we do ;-) |
Member
|
Ah, yes we do. Didn't read why the build was failing. 😁 Good idea in any case. We can change the interface later but for now this is good enough. I also expect noticeable startup time improvements once we move the NF coremods to this. |
Last commit published: 02c2e73818ad66a22dc348a98201c0259e749451. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #79' // https://github.com/neoforged/FancyModLoader/pull/79
url 'https://prmaven.neoforged.net/FancyModLoader/pr79'
content {
includeModule('net.neoforged.fancymodloader', 'junit-fml')
includeModule('net.neoforged.fancymodloader', 'loader')
includeModule('net.neoforged.fancymodloader', 'earlydisplay')
}
}
} |
|
@shartte, this PR introduces breaking changes.
|
Matyrobbrt
requested changes
May 5, 2024
loader/src/main/java/net/neoforged/fml/loading/CoreModScriptLoader.java
Outdated
Show resolved
Hide resolved
loader/src/main/java/net/neoforged/fml/loading/FMLServiceProvider.java
Outdated
Show resolved
Hide resolved
Mods must ship a separate Jar-file (for example via jar-in-jar) and mark it as FMLModType: LIBRARY to make it load above the GAME layer. They then must provide an implementation of ICoreMod via the Java ServiceLoader to contribute their transformers.
…o also covert that Added coremod tests
Matyrobbrt
requested changes
Jun 2, 2024
loader/src/main/java/net/neoforged/fml/loading/FMLServiceProvider.java
Outdated
Show resolved
Hide resolved
…der.java Co-authored-by: Matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
Matyrobbrt
approved these changes
Jun 2, 2024
Technici4n
pushed a commit
that referenced
this pull request
Jun 23, 2025
…`FileSystemProvider#newDirectoryStream` (#79) Fixes #78; use of `Files.walk` should now produce `Path`s that are as if resolved from the root path. This required a change to `JarContentsImpl` as it relied on the old (incorrect!) behavior where `walk` returned explicitly relative paths no matter what, as well as some changes to certain tests where similar assumptions were made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mods must ship a separate Jar-file (for example via jar-in-jar) and mark it as FMLModType: LIBRARY to make it load above the GAME layer. They then must provide an implementation of ICoreMod via the Java ServiceLoader to contribute their transformers.
This tries to avoid loading the script-engine based coremod library unless any modfile contains such coremod scripts.