Draft NEP 26 and Draft NEP 27: New NEPs describing onNEPXXPayment callbacks#169
Draft NEP 26 and Draft NEP 27: New NEPs describing onNEPXXPayment callbacks#169Jim8y merged 13 commits intoneo-project:masterfrom
Conversation
Fixes neo-project#168. Signed-off-by: Roman Khimov <roman@nspcc.ru>
|
Seems good to me, maybe we can use NEP-117 and NEP-111, something related to the parent? or we need to be consecutives? |
Huh, we don’t have to. Seems that’s exactly the case of special numbers:
|
Burguer neo? |
|
Link? We can add everything we have, I think it's pretty popular. |
https://github.com/neoburger/code/blob/beb433288bd7b0da9d2245e2a0ae5af5309da7ed/BurgerNEO.cs#L42 |
Signed-off-by: Roman Khimov <roman@nspcc.ru>
bNEO uses it and we can't say it's wrong. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Mediawiki is not Markdown. Signed-off-by: Roman Khimov <roman@nspcc.ru>
|
Added bNEO and also added a note on ASSERTs. |
|
@roman-khimov Could you update status and add NEP numbers? No.25 and No.26 will be OK. |
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Jimmy <jinghui@wayne.edu>
vncoelho
left a comment
There was a problem hiding this comment.
@roman-khimov, the details look good to me, apart for the first motivation paragraph that I will comment there.
On the other hand, I thought there were additional recommendation in the semantics.
In such case I think you can do an append to NEO-11 or NEP-27.
This does not necessary need a number. There is no sense to me.
@vncoelho YOU DO NOT CHANGE ANY EXISTING NEP. ITS NEP, A STANDARD, NOT SOME DOCUMENT YOU CAN UPDATE AND UPGRADE FROM TIME TO TIME. |
|
In my opinion it is a New Informational NEP or a documentation issue. Do we have any place to classify the NEPs? For example: https://eips.ethereum.org/informational |
|
Sorry it was not motivational part. It was below it. I already left some comments |
Add a bit more details, signify the need for script hash check. Signed-off-by: Roman Khimov <roman@nspcc.ru>
|
@roman-khimov Please update readme. We can merge this first incase approvals are reverted. @shargon |
The essence is the same, but the standard has its official name since neo-project/proposals#169. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
The essence is the same, but the standard has its official name since neo-project/proposals#169. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
A replacement of NEP11Payable and NEP17Payable. The essence is the same, but these standards have official name since neo-project/proposals#169. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Please add more implementation references.