Skip to content

delete plugin folder when uninstall plugin#860

Merged
erikzhang merged 15 commits intoneo-project:masterfrom
Jim8y:seperate-plugin-folder
Jun 10, 2022
Merged

delete plugin folder when uninstall plugin#860
erikzhang merged 15 commits intoneo-project:masterfrom
Jim8y:seperate-plugin-folder

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Apr 21, 2022 •
edited
Loading

Correspond to neo-project/neo#2696

@Jim8y Jim8y changed the base branch from master to develop April 21, 2022 21:00
@coveralls
Copy link

coveralls commented Apr 21, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2208503501

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 15.08%
Totals Coverage Status
Change from base Build 2186768199: 0.0%
Covered Lines: 107
Relevant Lines: 683
💛 - Coveralls

shargon
shargon reviewed Apr 22, 2022
View reviewed changes
Jim8y
Jim8y commented Apr 22, 2022
View reviewed changes
@shargon
Copy link
Member

shargon commented Apr 25, 2022

Tested @superboyiii ?

@erikzhang erikzhang changed the base branch from develop to master May 19, 2022 02:19
erikzhang
erikzhang reviewed May 25, 2022
View reviewed changes
Jinghui Liao added 3 commits May 24, 2022 20:16
Merge branch 'master' into seperate-plugin-folder
81bebb3
update plugin existance check
9dafb2f
Merge branch 'seperate-plugin-folder' of github.com:Liaojinghui/neo-n…
0096621 
…ode into seperate-plugin-folder

* 'seperate-plugin-folder' of github.com:Liaojinghui/neo-node:
  Use wallet factory (neo-project#861)
  Update main.yml
erikzhang
erikzhang reviewed May 25, 2022
View reviewed changes
@erikzhang
Copy link
Member

erikzhang commented May 25, 2022

Need to test.

@Jim8y
Copy link
Contributor Author

Jim8y commented May 26, 2022

Need to test.

@nicolegys ~~~ may you please help me test this?

@nicolegys
Copy link
Contributor

nicolegys commented May 26, 2022

Need to test.

@nicolegys ~~~ may you please help me test this?

I'll test it.

@nicolegys
Copy link
Contributor

nicolegys commented May 26, 2022

Need to test.

@nicolegys ~~~ may you please help me test this?

I'll test it.

Sorry, I can't test it now. The master branch of neo-modules is incompatible with neo-3.2.1-CI01365.

erikzhang
erikzhang reviewed May 27, 2022
View reviewed changes
@Jim8y
Copy link
Contributor Author

Jim8y commented May 28, 2022

@nicolegys neo-project/neo-modules#713 is merged, we can test this pr now

@nicolegys
Copy link
Contributor

nicolegys commented May 30, 2022

plugin can be uninstalled even though others depend on it.
1653909444(1)
seems something wrong when reading config.json
image

@Jim8y
Copy link
Contributor Author

Jim8y commented May 30, 2022

Seems the dependency check failed, i will check it out @nicolegys

@Jim8y
Copy link
Contributor Author

Jim8y commented Jun 1, 2022

@nicolegys fixed

@erikzhang
Copy link
Member

erikzhang commented Jun 7, 2022

@nicolegys Can you test it again?

@nicolegys
Copy link
Contributor

nicolegys commented Jun 7, 2022

plugin can be uninstalled even though others depend on it. 1653909444(1) seems something wrong when reading config.json image

This issue still exists. @Liaojinghui

@Jim8y
Copy link
Contributor Author

Jim8y commented Jun 7, 2022

@nicolegys that is because you did not use the correct plugin name, original plugin name is not ALL lowercases.

@nicolegys
Copy link
Contributor

nicolegys commented Jun 7, 2022

@nicolegys that is because you did not use the correct plugin name, original plugin name is not ALL lowercases.

You are right! But since both install and uninstall support ignoring case, we'd better maintain consistency.

nicolegys
nicolegys approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@nicolegys nicolegys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test pass

@erikzhang erikzhang merged commit 9512e05 into neo-project:master Jun 10, 2022
@superboyiii superboyiii mentioned this pull request Jun 14, 2022
Closed
13 tasks
Jim8y pushed a commit to Jim8y/neo-node that referenced this pull request Jun 25, 2022
Merge branch 'master' into mode-system
04c2d42 
* master:
  3.3.1 (neo-project#868)
  delete plugin folder when uninstall plugin (neo-project#860)
  upgrade CHANGELOG.md (neo-project#866)
  3.3.0 (neo-project#862)
  Sync Neo 3.2.1-CI01367: Update Logger (neo-project#865)
  Sync Neo 3.2.1-CI01365 (neo-project#864)

# Conflicts:
#	neo-cli/CLI/MainService.Plugins.cs
#	neo-cli/CLI/MainService.cs
#	neo-cli/config.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

+1 more reviewer

@nicolegys nicolegys nicolegys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jim8y @coveralls @shargon @erikzhang @nicolegys