Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Update plugins for Neo 3.2.1-CI-01368#713

Merged
erikzhang merged 12 commits intomasterfrom
CI01355
May 28, 2022
Merged

Update plugins for Neo 3.2.1-CI-01368#713
erikzhang merged 12 commits intomasterfrom
CI01355

Conversation

@erikzhang
Copy link
Member

@erikzhang erikzhang commented May 19, 2022

No description provided.

shargon
shargon reviewed May 19, 2022
View reviewed changes
@shargon
Copy link
Member

shargon commented May 19, 2022

NeoFS.API need to be updated

@ProDog
Copy link
Contributor

ProDog commented May 25, 2022

RpcClient needs to be updated:

neo-modules/src/RpcClient/Models/RpcValidator.cs

Line 29 in 12f4492

json["active"] = Active;

neo-modules/src/RpcClient/Models/RpcValidator.cs

Line 39 in 12f4492

Active = json["active"].AsBoolean()

@erikzhang erikzhang changed the title Update plugins for Neo 3.2.1-CI-01355 Update plugins for Neo 3.2.1-CI-01365 May 26, 2022
@Jim8y
Copy link
Contributor

Jim8y commented May 26, 2022

Coudld not compile

image

@erikzhang
Copy link
Member Author

erikzhang commented May 27, 2022

Ready to merge.

@ProDog
Copy link
Contributor

ProDog commented May 27, 2022

Rpc API calculatenetworkfee not working now, error:

System.ArgumentException
  HResult=0x80070057
  Message=The smart contract or address 0xfa03cb7b40072c69ca41f0ad3606a548f1d59966 is not found
  Source=Neo
  StackTrace:
   在 Neo.Wallets.Wallet.CalculateNetworkFee(DataCache snapshot, Transaction tx)
   在 Neo.Plugins.RpcServer.CalculateNetworkFee(JArray _params) 在 D:\Work\neo_code\neo-modules\src\RpcServer\RpcServer.Wallet.cs 中: 第 131 行
   在 Neo.Plugins.RpcServer.ProcessRequest(HttpContext context, JObject request) 在 D:\Work\neo_code\neo-modules\src\RpcServer\RpcServer.cs 中: 第 236 行

  此异常最初是在此调用堆栈中引发的: 
    [外部代码]
    Neo.Plugins.RpcServer.CalculateNetworkFee(Neo.IO.Json.JArray) (位于 RpcServer.Wallet.cs 中)
    Neo.Plugins.RpcServer.ProcessRequest(Microsoft.AspNetCore.Http.HttpContext, Neo.IO.Json.JObject) (位于 RpcServer.cs 中)

@erikzhang
Copy link
Member Author

erikzhang commented May 27, 2022

The smart contract or address 0xfa03cb7b40072c69ca41f0ad3606a548f1d59966 is not found

Did you open wallet?

@ProDog
Copy link
Contributor

ProDog commented May 28, 2022

Did you open wallet?

No, it's not need to open wallet before🤔

@erikzhang
Copy link
Member Author

erikzhang commented May 28, 2022

Can you send me the transaction?

@ProDog
Copy link
Contributor

ProDog commented May 28, 2022

Can you send me the transaction?

AMCUSgVoQJgAAAAAAAAAAAAAAAAAiioAAAFmmdXxSKUGNq3wQcppLAdAe8sD+oAAYAwFYWRhZGECTitXPAwUk37doqTFj89KkBXviq70hg8hKkAMFGaZ1fFIpQY2rfBBymksB0B7ywP6FMAfDAh0cmFuc2ZlcgwUz3bii9AGLEpHjuNVYQETGfPPpNJBYn1bUgEAKAwhA60ArU0EMl10rB2Zt6EYqogMz9NLhT2lvbSAmAtw+wZvQVbnsyc=

@ProDog
Copy link
Contributor

ProDog commented May 28, 2022

It's works if use RPC to open the wallet

@erikzhang
Copy link
Member Author

erikzhang commented May 28, 2022

Rpc API calculatenetworkfee not working now:

It should be fixed by neo-project/neo#2761

@erikzhang erikzhang changed the title Update plugins for Neo 3.2.1-CI-01365 Update plugins for Neo 3.2.1-CI-01367 May 28, 2022
@ProDog
Copy link
Contributor

ProDog commented May 28, 2022

It should be fixed by neo-project/neo#2761

It's works, tested ok.

@erikzhang
Copy link
Member Author

erikzhang commented May 28, 2022

It's works, tested ok.

Merge?

@ProDog
Copy link
Contributor

ProDog commented May 28, 2022

Merge?

OK

shargon
shargon previously approved these changes May 28, 2022
View reviewed changes
Jim8y
Jim8y previously approved these changes May 28, 2022
View reviewed changes
@Jim8y
Copy link
Contributor

Jim8y commented May 28, 2022

Now everything works fine

@erikzhang erikzhang dismissed stale reviews from Jim8y and shargon via 27831da May 28, 2022 14:45
@erikzhang erikzhang changed the title Update plugins for Neo 3.2.1-CI-01367 Update plugins for Neo 3.2.1-CI-01368 May 28, 2022
@erikzhang erikzhang merged commit 4526860 into master May 28, 2022
@erikzhang erikzhang deleted the CI01355 branch May 28, 2022 14:48
@Jim8y Jim8y mentioned this pull request May 28, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@shargon shargon shargon left review comments

@Jim8y Jim8y Jim8y left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erikzhang @shargon @ProDog @Jim8y