Fix contract hash#680
Merged
superboyiii merged 1 commit intoneo-project:copy-abi-to-neffrom Nov 27, 2020
Merged
Conversation
Merged
shargon
reviewed
Nov 21, 2020
|
|
||
| // TODO need to replace by ContractHash method | ||
|
|
||
| using var sb = new ScriptBuilder(); |
Member
There was a problem hiding this comment.
ContractCreate push the contract to the stack, so we can read the hash from the execution result
Contributor
Author
There was a problem hiding this comment.
That's too bad, we should have a simple way to calculate contract hash, not by vm execution.
Member
|
I will merge this first, then we could review in #676. |
shargon
added a commit
that referenced
this pull request
Dec 1, 2020
* Copy abi to nef Related: neo-project/neo#1973, neo-project/neo-devpack-dotnet#378 * Update neo-cli/CLI/MainService.cs * Fix deploy * fix contract hash (#680) * update to neo * Use helper * Clean usings Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: Luchuan <luchuan@ngd.neo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait neo-project/neo#2044