Skip to content

Allow neo-cli to switch between RocksDB and LevelDB#451

Closed
shargon wants to merge 3 commits intoneo-project:masterfrom
shargon:rocks-db
Closed

Allow neo-cli to switch between RocksDB and LevelDB#451
shargon wants to merge 3 commits intoneo-project:masterfrom
shargon:rocks-db

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Aug 27, 2019

Require changes when neo-project/neo#1063 was merged

If you want to test RocksDB PR, you can use this branch

This was referenced Aug 27, 2019
@vncoelho
Copy link
Copy Markdown
Member

Looks simple, @shargon. Nice job.
In this sense, even after #1063 we are going to be able to use both of them?

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Aug 27, 2019

Yes, we can do real benchmarks between them now

@@ -1,22 +1,31 @@

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes will be removed on the last version


<ItemGroup>
<ProjectReference Include="..\..\neo\neo\neo.csproj" />
</ItemGroup>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes will be removed on the last version

@shargon shargon requested a review from erikzhang August 27, 2019 13:35
@erikzhang erikzhang closed this Dec 1, 2019
@erikzhang erikzhang reopened this Dec 1, 2019
@erikzhang erikzhang closed this Dec 1, 2019
@shargon shargon deleted the rocks-db branch December 1, 2019 15:29
Jim8y pushed a commit to Jim8y/neo-node that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants