Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Updated .editorconfig & Applied Changes#866

Merged
shargon merged 1 commit intoneo-project:masterfrom
cschuchardt88:editorconfig-update
Jan 10, 2024
Merged

Updated .editorconfig & Applied Changes#866
shargon merged 1 commit intoneo-project:masterfrom
cschuchardt88:editorconfig-update

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jan 9, 2024 •
edited
Loading

  • Updated .editorconfig and run code analyze
  • Added .gitattibutes

Used .editorconfig from neo repo

@superboyiii
Copy link
Member

superboyiii commented Jan 9, 2024 •
edited
Loading

Is this safe that namespace changed after format?
1704795943874

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jan 9, 2024

hmm that's weird!!! 😭

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jan 9, 2024

@superboyiii Must be you. I see no such change.

image

@superboyiii
Copy link
Member

superboyiii commented Jan 9, 2024 •
edited
Loading

Maybe I'm in the wrong way for your editconfig? How should it be applied?
I'm running code analysis on solution.
image

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jan 9, 2024

@superboyiii this is what i ran
image

@superboyiii
Copy link
Member

superboyiii commented Jan 10, 2024 •
edited
Loading

@superboyiii this is what i ran image

Yes, this works when I turned Fix all warnings and errors set in EditorConfig to Fix analyzer warnings and errors set in EditorConfig

@shargon shargon merged commit 99b62d4 into neo-project:master Jan 10, 2024
@shargon shargon deleted the editorconfig-update branch January 10, 2024 08:09
Jim8y added a commit to Jim8y/neo-modules that referenced this pull request Jan 10, 2024
@Jim8y
Merge branch 'master' of github.com:neo-project/neo-modules
555ba00 
* 'master' of github.com:neo-project/neo-modules:
  Ensure max length (neo-project#845)
  Update .editorconfig and run code analyze (neo-project#866)
  Added AspNetCore (neo-project#863)
  RcpServer: Fixed CORS and Basic Auth (neo-project#812)
  Fix response from getversion due to WS removal (neo-project#859)
  Local dev setup (neo-project#861)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@shargon shargon shargon approved these changes

@superboyiii superboyiii superboyiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cschuchardt88 @superboyiii @shargon