Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Fix workflow#857

Merged
shargon merged 3 commits intoneo-project:masterfrom
Ashuaidehao:refac-workflow
Dec 6, 2023
Merged

Fix workflow#857
shargon merged 3 commits intoneo-project:masterfrom
Ashuaidehao:refac-workflow

Conversation

@Ashuaidehao
Copy link
Contributor

Fix workflow

@shargon shargon merged commit cde2916 into neo-project:master Dec 6, 2023
run: |
sudo apt install xmlstarlet
find -name Directory.Build.props | xargs xmlstarlet sel -N i=http://schemas.microsoft.com/developer/msbuild/2003 -t -v "concat('::set-output name=version::v',//i:VersionPrefix/text())" | xargs echo
find -maxdepth 1 -name Directory.Build.props | xargs xmlstarlet sel -N i=http://schemas.microsoft.com/developer/msbuild/2003 -t -v "concat('::set-output name=version::v',//i:VersionPrefix/text())" | xargs echo
Copy link
Member

@cschuchardt88 cschuchardt88 Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could of did run: echo "VERSION=${GITHUB_REF/refs\/tags\/v/}" >> $GITHUB_ENV than do

dotnet build someproject.csproj -p:VersionPrefix=${VERSION}

This get new tag version and sets VersionPrefix in a project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using this workflow to create new tag now, so couldn't find new tags from git. I have no ideas how to make the workflow more usable, since it has already been a hardcoded solution.

Jim8y added a commit to Jim8y/neo-modules that referenced this pull request Dec 13, 2023
* 'master' of github.com:neo-project/neo-modules:
  Fix workflow (neo-project#857)
  Fix stack exception name (neo-project#855)
  update workflow (neo-project#856)
  Refac build configs (neo-project#846)
  Hotfix for neo-project#850 (neo-project#853)
  Fix RpcNativeContract (neo-project#851)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants