This repository was archived by the owner on Nov 10, 2025. It is now read-only.
MaxParamsDepth and MaxRequestBodySize in RpcServer#827
Merged
superboyiii merged 6 commits intomasterfrom Nov 8, 2023
Merged
Conversation
vncoelho
reviewed
Sep 18, 2023
Member
vncoelho
left a comment
There was a problem hiding this comment.
I am not sure if this will solve the issue completely.
But these limits are needed.
cschuchardt88
approved these changes
Sep 18, 2023
Member
Author
|
@superboyiii could you test it? |
Jim8y
approved these changes
Sep 26, 2023
Member
Author
|
Ping @superboyiii |
Member
|
@shargon @Liaojinghui @superboyiii this doesnt fix the problem..... it has to do with a string in a parameter WitnessCondition keep creating an object, that could eat memory if crafted right See: |
Member
|
here is an example of what im talking about example.txt |
Member
Author
|
But this
But this send a lot of accounts not Rules, is a different one. |
Merged
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 23, 2023
A part of #3131, follow the neo-project/neo-modules#827. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 23, 2023
A part of #3131, follow the notion of neo-project/neo-modules#827, but don't restrict request line size due to golang/go#15494. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 23, 2023
A part of #3131, follow the neo-project/neo-modules#827. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 23, 2023
A part of #3131, follow the notion of neo-project/neo-modules#827, but don't restrict request line size due to golang/go#15494. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 23, 2023
A part of #3131, follow the neo-project/neo-modules#827. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 23, 2023
A part of #3131, follow the notion of neo-project/neo-modules#827, but don't restrict request line size due to golang/go#15494. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close neo-project/neo#2950