DBFTPlugin: adapt Conflicts attribute verification#802
DBFTPlugin: adapt Conflicts attribute verification#802superboyiii merged 6 commits intoneo-project:masterfrom
Conversation
Depends on neo-project/neo#2818, see the neo-project/neo#2818 (comment). Signed-off-by: Anna Shaleva <anna@nspcc.ru>
|
Yes, I will build and test. |
Not yet, only unit-tests without dBFT plugin. I'll try to run four-nodes private network with two C# and two neo-go nodes with the help of neo-bench and see how it goes. |
shargon
left a comment
There was a problem hiding this comment.
Wait for neo-project/neo#2818
Fetch the update from core: neo-project/neo#2818 (comment).
|
@superboyiii, I've updated the dBFT plugin based on your test and neo-project/neo#2818 (comment). You'll need to use the updated version in your test. |
Works well! |
Use new API from neo-project/neo@ee7333f.
bbbaccc to
9fafe75
Compare
|
@superboyiii, @shargon, just a reminder, but this needs to merged as well before 3.6 release. Otherwise neo-project/neo#2818 won't be completely functional. |
* master: remove Travis logo (neo-project#818) Fix 3.6 (neo-project#816) DBFTPlugin: adapt Conflicts attribute verification (neo-project#802)
Depends on neo-project/neo#2818, see the neo-project/neo#2818 (comment).
@vncoelho, we'll need to add the proper link to the core module to .csproj file to build this PR. Could you test it, please?