Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Unified precision#505

Merged
superboyiii merged 33 commits intoneo-project:masterfrom
Ashuaidehao:unified-precision
Feb 3, 2021
Merged

Unified precision#505
superboyiii merged 33 commits intoneo-project:masterfrom
Ashuaidehao:unified-precision

Conversation

@Ashuaidehao
Copy link
Copy Markdown
Contributor

@Ashuaidehao Ashuaidehao commented Feb 3, 2021

ApplicationLog and RpcNep17Tracker will return BigInteger via RPC.
Relate to #496

Ashuaidehao and others added 13 commits March 12, 2019 10:40
@Ashuaidehao
Merge pull request #1 from neo-project/master
78ebb99 
update 0312
@Ashuaidehao
Merge pull request #2 from neo-project/master
957d4d6 
update 2.10
@Ashuaidehao
Merge pull request #3 from neo-project/master
9980a01 
Use IPersistencePlugin and batch Application Log writes. (#62)
@Ashuaidehao
Merge pull request #4 from neo-project/master
0a3f23e 
Sync20190506
@Ashuaidehao
Merge branch 'master' of https://github.com/Ashuaidehao/neo-plugins
7de8bf3
@Ashuaidehao
Merge https://github.com/neo-project/neo-plugins
0900c84
@Ashuaidehao
Merge https://github.com/neo-project/neo-modules
3426793
@Ashuaidehao
Merge https://github.com/neo-project/neo-modules
a797bd0
@Ashuaidehao
Merge https://github.com/neo-project/neo-modules
cf65368
@Ashuaidehao
Merge https://github.com/neo-project/neo-modules
44b7e93
@Ashuaidehao
Merge https://github.com/neo-project/neo-modules
2b2cd28
@Ashuaidehao
Rpc Return BigInteger
b142783
@chenzhitong
Unified precision 2
a2c8996
erikzhang
erikzhang reviewed Feb 3, 2021
View reviewed changes
@Ashuaidehao @erikzhang
Update src/ApplicationLogs/LogReader.cs
3c61e60 
Co-authored-by: Erik Zhang <erik@neo.org>
@erikzhang erikzhang mentioned this pull request Feb 3, 2021
Closed
@bettybao1209
Copy link
Copy Markdown
Contributor

bettybao1209 commented Feb 3, 2021

Is it ok that GetWalletBalance in https://github.com/neo-project/neo-modules/blob/master/src/RpcServer/RpcServer.Wallet.cs#L78 return decimal? Since GetAvailable in neo core returns decimal.

@shargon shargon mentioned this pull request Feb 3, 2021
Merged
shargon
shargon previously approved these changes Feb 3, 2021
View reviewed changes
@bettybao1209 bettybao1209 mentioned this pull request Feb 3, 2021
Closed
@chenzhitong
Copy link
Copy Markdown
Contributor

chenzhitong commented Feb 3, 2021

RpcServer.Wallet.cs Line 83
json["balance"] = wallet.GetAvailable(asset_id).Value.ToString();

shargon
shargon previously approved these changes Feb 3, 2021
View reviewed changes
@ProDog
Copy link
Copy Markdown
Contributor

ProDog commented Feb 3, 2021

Tested OK.

@ProDog ProDog self-requested a review February 3, 2021 10:47
ProDog
ProDog previously approved these changes Feb 3, 2021
View reviewed changes
@cloud8little
Copy link
Copy Markdown
Contributor

cloud8little commented Feb 3, 2021

Ready to merge. @superboyiii

@roman-khimov
Copy link
Copy Markdown
Contributor

roman-khimov commented Feb 3, 2021

This effectively reverts #485 and parts of #378 and makes RPC interface a little less friendly (one needs to get/store proper decimals to correctly process these values).

chenzhitong
chenzhitong previously approved these changes Feb 3, 2021
View reviewed changes
@chenzhitong chenzhitong mentioned this pull request Feb 3, 2021
Closed
erikzhang
erikzhang reviewed Feb 3, 2021
View reviewed changes
@Ashuaidehao Ashuaidehao dismissed stale reviews from chenzhitong, ProDog, and shargon via e639cbe February 3, 2021 11:18
Ashuaidehao and others added 3 commits February 3, 2021 19:19
@cloud8little
Copy link
Copy Markdown
Contributor

cloud8little commented Feb 3, 2021

This effectively reverts #485 and parts of #378 and makes RPC interface a little less friendly (one needs to get/store proper decimals to correctly process these values).

since the rpc function is a generic function, and I think it is reasonable to give the control of converting the data to the upper layer applcation (include sdk).

@superboyiii superboyiii merged commit 092ced1 into neo-project:master Feb 3, 2021
@roman-khimov roman-khimov mentioned this pull request Feb 7, 2021
Closed
@ixje ixje mentioned this pull request Feb 23, 2021
Closed
1 task
@roman-khimov roman-khimov mentioned this pull request Mar 15, 2021
Closed
joeqian10 pushed a commit to joeqian10/neo-modules that referenced this pull request Apr 7, 2021
@Ashuaidehao @chenzhitong
@erikzhang @shargon @joeqian10
Unified precision (neo-project#505)
f423200 
* Rpc Return BigInteger

* Unified precision 2

* Update src/ApplicationLogs/LogReader.cs

Co-authored-by: Erik Zhang <erik@neo.org>

* refac

* update

* update

* update

* Optimize

* update

* update wallet

* update

* Update src/RpcClient/Models/RpcApplicationLog.cs

Co-authored-by: Erik Zhang <erik@neo.org>

* refac

* long

* Fix RpcNep17Tracker

* More fix

Co-authored-by: 陈志同 <chenzhitong12@qq.com>
Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@erikzhang erikzhang erikzhang approved these changes

@shargon shargon shargon left review comments

@chenzhitong chenzhitong chenzhitong left review comments

@ProDog ProDog ProDog left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Ashuaidehao @bettybao1209 @shargon @chenzhitong @ProDog @cloud8little @roman-khimov @erikzhang @superboyiii