Skip to content

Check dotnet format in travis#94

Merged
igormcoelho merged 8 commits intomasterfrom
dotnet-format
Aug 26, 2019
Merged

Check dotnet format in travis#94
igormcoelho merged 8 commits intomasterfrom
dotnet-format

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Aug 25, 2019

This will prevent to push any format error

Related to neo-project/neo#982

This will prevent to push any format error

Related to neo-project/neo#982
@shargon
Copy link
Copy Markdown
Member Author

shargon commented Aug 25, 2019

@igormcoelho it seems that CRLF is checked here, isn't it?

@igormcoelho
Copy link
Copy Markdown
Contributor

Let's format this before 93... it's too complicated to review. This code was never properly indented 😂

@igormcoelho
Copy link
Copy Markdown
Contributor

@shargon can you reopen this in your branch? I cannot write over neo directly, I don't know why...

@igormcoelho
Copy link
Copy Markdown
Contributor

Ok, I created another repo clone with write access here. Let's fix travis before 94, so changes will be much easier to track (compiler is tricky).

@igormcoelho
Copy link
Copy Markdown
Contributor

Man, this code is so non-formatted... I don't know what to do here. Let's just pass these basic changes for now... and we format it in time perhaps...

igormcoelho
igormcoelho previously approved these changes Aug 26, 2019
Copy link
Copy Markdown
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, we should merge this ASAP (24hrs and counting).

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Aug 26, 2019

If tests pass, we should merge this ASAP (24hrs and counting).

image

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Aug 26, 2019

We should unify in a future the name of the folders across all the projects

@igormcoelho
Copy link
Copy Markdown
Contributor

Yes.. in fact this one I like more: src and tests. Just a typo causing headache here 😂

@vncoelho
Copy link
Copy Markdown
Member

image

Copy link
Copy Markdown
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm positive, tests will pass 💪

Copy link
Copy Markdown
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Aug 26, 2019

PASSED!

@vncoelho
Copy link
Copy Markdown
Member

I will restart travis to be sure it passed. aehuaheuhea ajajaj

@igormcoelho
Copy link
Copy Markdown
Contributor

double-check is always good precaution 👍
😂

@igormcoelho igormcoelho merged commit b73bd74 into master Aug 26, 2019
@igormcoelho igormcoelho deleted the dotnet-format branch August 26, 2019 18:58
@igormcoelho
Copy link
Copy Markdown
Contributor

Sorry guys, we need to review 93. This is blocking us.

Jim8y pushed a commit that referenced this pull request Aug 3, 2025
* Check dotnet format in travis 
This will prevent to push any format error
Related to neo-project/neo#982
* Update .travis.yml
* Update .travis.yml
* dotnet format
* updated travis
* few small changes on final line break
* test -> tests
* more tests
Jim8y pushed a commit that referenced this pull request Aug 18, 2025
* Check dotnet format in travis 

This will prevent to push any format error

Related to neo-project/neo#982

* Update .travis.yml

* Update .travis.yml

* dotnet format

* updated travis

* few small changes on final line break

* test -> tests

* more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants