Add: add runtime.transaction#859
Add: add runtime.transaction#859Jim8y merged 4 commits intoneo-project:masterfrom Jim8y:runtime-transaction
Conversation
| public static extern Transaction Transaction | ||
| { | ||
| [Syscall("System.Runtime.GetScriptContainer")] | ||
| get; | ||
| } |
There was a problem hiding this comment.
Why dont you just change ScriptContainer return type to Transaction. It will alway be Transaction and its like that in neo-go
There was a problem hiding this comment.
Delete in the future maybe, but I don't want just remove it.
There was a problem hiding this comment.
But they can alway call GetScriptContainer syscall and there is no reason to keep it like that? mark as obsolete than?
There was a problem hiding this comment.
But they can alway call
GetScriptContainersyscalland there is no reason to keep it like that? mark asobsoletethan?
Mark it then, I just don't like the idea of change exiting interface arbitrarily.
There was a problem hiding this comment.
In fact it could return a block if you deploy a consensus wallet
There was a problem hiding this comment.
How can you make your code executed in a block context?
There was a problem hiding this comment.
@shargon What is the Trigger? Cause the only other place you can invoke something other than at the Application trigger is, Verification. Other than that contracts don't get loaded in another triggers. All code in other triggers pass in null
There was a problem hiding this comment.
Here you can see that it was used the block as scriptContainer (as verification)
There was a problem hiding this comment.
Can it be triggered in contract?
* add runtime.transaction * add Obsolete to ScriptContainer --------- Co-authored-by: Shargon <shargon@gmail.com>
* add runtime.transaction * add Obsolete to ScriptContainer --------- Co-authored-by: Shargon <shargon@gmail.com>
Closes #858