Skip to content

Revert "publish neon to myget/github packages"#395

Merged
erikzhang merged 2 commits intoneo-project:masterfrom
shargon:revert-393
Nov 28, 2020
Merged

Revert "publish neon to myget/github packages"#395
erikzhang merged 2 commits intoneo-project:masterfrom
shargon:revert-393

Conversation

@shargon
Copy link
Member

@shargon shargon commented Nov 21, 2020

Related to #393

@shargon shargon requested review from devhawk and erikzhang November 21, 2020 12:40
@erikzhang
Copy link
Member

@devhawk The package of neon is too large. Maybe we can publish the library only (not include the dotnet tools).

@devhawk
Copy link
Contributor

devhawk commented Nov 21, 2020

@devhawk The package of neon is too large. Maybe we can publish the library only (not include the dotnet tools).

The tool is the part that matters. I'm not sure what projects use the library directly.

Based on my local testing, --include-source is creating an additional 18mb symbols package. Is that getting uploaded to myget? I don't think we need to tool package to include symbols and source

@shargon
Copy link
Member Author

shargon commented Nov 22, 2020

Shall I remove --include-source first?

@erikzhang
Copy link
Member

--include-source is creating an additional 18mb symbols package.

Even without the symbols package, the nupkg file itself is 18MB in size. MyGet only has 100MB of space.

@devhawk
Copy link
Contributor

devhawk commented Nov 24, 2020

MyGet only has 100MB of space.

Could we publish at least the neon tool somewhere other than myget? Azure artifacts free tier is 2gb and it's only $2 USD / month / GB above that. Or we could use sleet to publish a feed on AWS or Azure storage - that would be under a $1 USD / month

@erikzhang erikzhang merged commit 4f6e384 into neo-project:master Nov 28, 2020
@shargon shargon deleted the revert-393 branch November 29, 2020 11:45
chenzhitong pushed a commit to chenzhitong/neo-devpack-dotnet that referenced this pull request Dec 7, 2020
shargon added a commit that referenced this pull request Dec 16, 2020
* Upgrade target framework.

* Revert "Upgrade target framework."

This reverts commit 6b0c49c.

* Safe Attribute

* Update Contract1.cs (#398)

* Revert "publish neon to myget/github packages" (#395)

* Remove Contract.Create、Contract.Update、Contract.Destroy; Add Contract.CallNative.

* Update

* remove CallNative

* Update templates/Template.CSharp/Contract1.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* Update templates/Template.CSharp/Contract1.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* Update tests/Neo.SmartContract.Framework.UnitTests/TestClasses/Contract_CreateAndUpdate.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* public

* Update

* Update call

* Fix more UT

* Update hashes

* Mock contract create

* Fix more UT

* Fix UT

* More fixes

* More fixes

* More UT

* Fix UT's

* dotnet-format

* Fix Last test

* Update

* Remove private properties

* Fixed UT

* disable warning CS0626

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Co-authored-by: Erik Zhang <erik@neo.org>
Jim8y pushed a commit that referenced this pull request Aug 3, 2025
* Upgrade target framework.
* Revert "Upgrade target framework."
This reverts commit 6b0c49c.
* Safe Attribute
* Update Contract1.cs (#398)
* Revert "publish neon to myget/github packages" (#395)
* Remove Contract.Create、Contract.Update、Contract.Destroy; Add Contract.CallNative.
* Update
* remove CallNative
* Update templates/Template.CSharp/Contract1.cs
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
* Update templates/Template.CSharp/Contract1.cs
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
* Update tests/Neo.SmartContract.Framework.UnitTests/TestClasses/Contract_CreateAndUpdate.cs
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
* public
* Update
* Update call
* Fix more UT
* Update hashes
* Mock contract create
* Fix more UT
* Fix UT
* More fixes
* More fixes
* More UT
* Fix UT's
* dotnet-format
* Fix Last test
* Update
* Remove private properties
* Fixed UT
* disable warning CS0626
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Co-authored-by: Erik Zhang <erik@neo.org>
Jim8y pushed a commit that referenced this pull request Aug 18, 2025
* Upgrade target framework.

* Revert "Upgrade target framework."

This reverts commit 6b0c49c.

* Safe Attribute

* Update Contract1.cs (#398)

* Revert "publish neon to myget/github packages" (#395)

* Remove Contract.Create、Contract.Update、Contract.Destroy; Add Contract.CallNative.

* Update

* remove CallNative

* Update templates/Template.CSharp/Contract1.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* Update templates/Template.CSharp/Contract1.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* Update tests/Neo.SmartContract.Framework.UnitTests/TestClasses/Contract_CreateAndUpdate.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* public

* Update

* Update call

* Fix more UT

* Update hashes

* Mock contract create

* Fix more UT

* Fix UT

* More fixes

* More fixes

* More UT

* Fix UT's

* dotnet-format

* Fix Last test

* Update

* Remove private properties

* Fixed UT

* disable warning CS0626

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Co-authored-by: Erik Zhang <erik@neo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants