Merged
Conversation
Tommo-L
previously approved these changes
Sep 16, 2020
lightszero
previously approved these changes
Sep 16, 2020
Member
lightszero
left a comment
There was a problem hiding this comment.
I had fix this a little.
Parse 2string,3string,4string overload.
Add a throw for other overload.
Add parse for String::concat(string[] args).
lightszero
previously approved these changes
Sep 16, 2020
Tommo-L
previously approved these changes
Sep 16, 2020
Member
|
Tested? @neo-project/ngd-shanghai |
Member
Author
|
ready to merge? |
erikzhang
approved these changes
Sep 18, 2020
Jim8y
pushed a commit
that referenced
this pull request
Aug 3, 2025
* Fix concat * Add comment * dotnet format * fix concat parse * fix format * format * add enter * Remove enter Co-authored-by: lights <lightsever@hotmail.com>
Jim8y
pushed a commit
that referenced
this pull request
Aug 18, 2025
* Fix concat * Add comment * dotnet format * fix concat parse * fix format * format * add enter * Remove enter Co-authored-by: lights <lightsever@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #355