Skip to content

Optimize const executions#252

Merged
lightszero merged 11 commits intomasterfrom
optimize-static-math
Apr 29, 2020
Merged

Optimize const executions#252
lightszero merged 11 commits intomasterfrom
optimize-static-math

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Apr 24, 2020

Optimized NOTEQUAL, SIGN,ABS, NEGATE,INC, DEC,ADD,SUB,MUL, DIV, MOD,ISNULL

@shargon shargon requested a review from lightszero April 24, 2020 17:06
lightszero
lightszero previously approved these changes Apr 26, 2020
{
return Optimize(script, new OptimizeParserType[]
{
//OptimizeParserType.DELETE_DEAD_CODDE,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/neo-project/neo-devpack-dotnet/pull/219/files added a bug that make this optimization fail

@shargon shargon changed the title Optimize static math Optimize const executions Apr 27, 2020
@shargon
Copy link
Copy Markdown
Member Author

shargon commented Apr 27, 2020

@neo-project/ngd-shanghai after abi changes seems that coverage it's wrong calculated sometimes.

Take a look to these changes, they decrease the coverage 15%

487b158

527b19e

@shargon shargon requested review from Tommo-L and lightszero April 27, 2020 13:49
@shargon
Copy link
Copy Markdown
Member Author

shargon commented Apr 29, 2020

@lightszero could be merged?

@lightszero lightszero merged commit 12f385f into master Apr 29, 2020
@lightszero lightszero deleted the optimize-static-math branch April 29, 2020 10:07
Jim8y pushed a commit that referenced this pull request Aug 3, 2025
* Optimize static math
* dotnet format
* Add DIV check
* Fix multiple optimizations
* Fix UT
* Rename
* Add BigInteger MaxSize
* Check that BigInteger it's <=32 bytes length
* Clean code
* Optimize ISNULL
Jim8y pushed a commit that referenced this pull request Aug 18, 2025
* Optimize static math

* dotnet format

* Add DIV check

* Fix multiple optimizations

* Fix UT

* Rename

* Add BigInteger MaxSize

* Check that BigInteger it's <=32 bytes length

* Clean code

* Optimize ISNULL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants