Merged
Conversation
#196 because Insert a Opcode Convert but newarr still get last opcode for a PushNumber 2.add some unittest for it.
Tommo-L
approved these changes
Mar 12, 2020
| return null; | ||
| } | ||
|
|
||
| static readonly byte[] OwnerVar = new byte[] { 0xf6, 0x64, 0x43, 0x49, 0x8d, 0x38, 0x78, 0xd3, 0x2b, 0x99, 0x4e, 0x4e, 0x12, 0x83, 0xc6, 0x93, 0x44, 0x21, 0xda, 0xfe }; |
Contributor
There was a problem hiding this comment.
Forget me, we have already supported global static variables, right?
belane
approved these changes
Mar 12, 2020
Member
|
Tested, it works well now. |
superboyiii
approved these changes
Mar 13, 2020
Jim8y
pushed a commit
that referenced
this pull request
Aug 3, 2025
#196 because Insert a Opcode Convert but newarr still get last opcode for a PushNumber 2.add some unittest for it.
Jim8y
pushed a commit
that referenced
this pull request
Aug 18, 2025
#196 because Insert a Opcode Convert but newarr still get last opcode for a PushNumber 2.add some unittest for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@superboyiii
1.fix a bug about convert func:#196
we Insert a Opcode Convert,but compiler read last opcode for a number when parse Opcode newarr.Compiler will get a error opcode:Convert. had fix it.
2.add some unittest for it.
notice: