NEP5 Template for NEO3 by belane · Pull Request #187 · neo-project/neo-devpack-dotnet

belane · 2020-02-01T21:12:27Z

C Sharp version of the NEP5 template for NEO3 (https://github.com/neo-project/neo/issues/973).

As the nep-5 standard, it includes totalSupply, name, symbol, decimals, balanceOf and transfer methods, and the transfer event.

shargon · 2020-02-03T08:31:42Z

We need to wait for neo-project/neo#1432

superboyiii · 2020-02-03T09:54:28Z

Good work, I'll test this.

superboyiii · 2020-02-04T04:04:37Z

I tried this nep5 template on my local environment. It was deployed successfully and then I invoked some static methods such like name or decimals which all returned correct result.
However, when I invoked deploy method, I found tx.Cosigner is null which caused execution failed.

Is there any more we should adjust on compiler? Does it support this kind of style? @lightszero

shargon · 2020-02-04T14:36:34Z

Cosigners should be [0], not null, @superboyiii please check neo-project/neo-node#539

doubiliu · 2020-02-04T17:16:22Z

Format needs to be modified

templates/Template.NEP5.CSharp/NEP5.cs

erikzhang · 2020-02-05T05:14:13Z

@belane Did you see https://github.com/neo-project/examples/tree/3.0/nep-5/csharp/NEP5?

superboyiii · 2020-02-05T07:24:42Z

Cosigners should be [0], not null, @superboyiii please check neo-project/neo-node#539

@shargon I've checked neo-project/neo-node#539, that's OK. But there's another issue that Cosigners is always [0] here which makes usage is always null so that checkwitness isn't able to pass when invoke deploy.

shargon · 2020-02-05T10:20:34Z

You received HALT, and should be FAULT, isn't it? @superboyiii

superboyiii · 2020-02-05T10:48:06Z

You received HALT, and should be FAULT, isn't it? @superboyiii

Yes, that's it. Now I add some logs on every step of Deploy(), you could see that it returns false, but finally receive HALT.

shargon · 2020-02-05T14:26:09Z

This CheckWitnessInternal return false, so the execution must be FAULT :S

superboyiii · 2020-02-05T14:51:41Z

Yes, that's strange.

belane · 2020-02-05T15:12:34Z

@belane Did you see https://github.com/neo-project/examples/tree/3.0/nep-5/csharp/NEP5?

@erikzhang yes, what do you prefer? move it, merge or close?

superboyiii · 2020-02-06T10:33:18Z

@erikzhang I think two different templates could exist together since they're in absolutely different repositories. We just need to ensure their methods all meet nep5 standard and work well. This template is using Object-oriented style which is valueable for testing purpose. We can test many features on it.

templates/Template.NEP5.CSharp/NEP5.Admin.cs

doubiliu · 2020-02-09T14:35:36Z

@erikzhang Both templates are great works. The NEP5 template in the neo/example provides users with a basic Token template, while the Belance's is an extension to meet deeper needs, or we can modify the name of Belance's template to Crowdfunding template.

templates/Template.NEP5.CSharp/NEP5.Methods.cs

templates/Template.NEP5.CSharp/NEP5.Crowdsale.cs

shargon

Good template :)

tests/Neo.Compiler.MSIL.UnitTests/Utils/NeonTestTool.cs

tests/Neo.Compiler.MSIL.UnitTests/Utils/TestEngine.cs

templates/Template.NEP5.CSharp/NEP5.Crowdsale.cs

templates/Template.NEP5.CSharp/NEP5.Admin.cs

shargon · 2020-03-16T14:49:04Z

templates/Template.NEP5.CSharp/NEP5.Admin.cs

+            {
+                return false;
+            }
+            Contract.Update(script, manifest);


Shall we send our neo and gas to the next contract or this should be made in the core? 🤔

I think we should move asset to the next contract in the core, as NEO, GAS and data all are protocol layer things. For me, we can treat NEO and GAS as one special data type/properties in contract, so when we update or destory contract, we should handle them.

What do you think? @erikzhang @lightszero

Not sure which is the best option. 🤔
It would prevent losing assets in hyperspace, but on the other hand, it may exceed the functions of the core.

shargon · 2020-03-16T14:49:36Z

templates/Template.NEP5.CSharp/NEP5.Admin.cs

+                return false;
+            }
+
+            Contract.Destroy();


Shall we send our neo and gas to the owner or this should be made in the core? 🤔

Perhaps there should be a check, if there is neo or gas it returns false.

If one contract hasn't set the verificaiton trigger correctly, it may can't be destoryed never.

These kind of controls are good, we've recommended before, but they are specific to each project.
Each project must implement the measures that fit its business model. As @Tommo-L says if a contract does not include Verification, it is enough to send 1 GAS to prevent them from migrating (or destroy) the contract.

vncoelho

Very good job @belane.

lightszero

code like this is very slow,very very very slow.
and it's expensive,I don't think it is a good idea in template.

//this is a function,compiler do not optimize it.,it will write 20 times
 Owner=>new byte[] { 0xf6, 0x64, 0x43, 0x49, 0x8d, 0x38, 0x78, 0xd3, 0x2b, 0x99, 0x4e, 0x4e, 0x12, 0x83, 0xc6, 0x93, 0x44, 0x21, 0xda, 0xfe };

please use

//compiler can optimze it to a const.
static readonly byte[] owner_var=new byte[] { 0xf6, 0x64, 0x43, 0x49, 0x8d, 0x38, 0x78, 0xd3, 0x2b, 0x99, 0x4e, 0x4e, 0x12, 0x83, 0xc6, 0x93, 0x44, 0x21, 0xda, 0xfe };

templates/Template.NEP5.CSharp/NEP5.cs

nicolegys · 2020-03-18T09:02:22Z

We need to send notification when destroying the sc, otherwise the plugin RpcNep5Tracker won't know it, the balance of the asset will still exist in its storage.

erikzhang · 2020-03-18T10:49:29Z

You can check the change set in OnPersist.

belane · 2020-03-19T12:53:29Z

We need to send notification when destroying the sc, otherwise the plugin RpcNep5Tracker won't know it, the balance of the asset will still exist in its storage.

In the past we haven't used this kind of notifications, as Erik says you can use OnPersist better since not all projects will include these notifications. But it's something we can consider adding in the future.

superboyiii · 2020-03-20T02:35:04Z

@lightszero Could you review it again? I think it's OK now.

* sc and tests * dotnet format * Prepare for new SYSCALL * Add FeaturesAttribute * post build SC compilation * revert GetCurrentTransaction * Add ContractId * fix Deploy * check null balances * updates from master * Update crowdsale get balance Co-Authored-By: Luchuan <luchuan@ngd.neo.org> * ToBigInteger * dotnet format * migrate args * NeoToken little-endian Co-Authored-By: GripZhang <xiuboard@foxmail.com> * GasToken little-endian Co-Authored-By: GripZhang <xiuboard@foxmail.com> * totalSupply and ut * supply factor * shargon improvements * li optimizations * more changes * add 214 Co-authored-by: Shargon <Shargon@gmail.com> Co-authored-by: Luchuan <luchuan@ngd.neo.org> Co-authored-by: GripZhang <xiuboard@foxmail.com> Co-authored-by: lights li <lightsever@hotmail.com>

sc and tests

54cffa8

belane mentioned this pull request Feb 1, 2020

[WIP] NEP5 Template for NEO3 #90

Closed

belane and others added 2 commits February 1, 2020 22:31

dotnet format

12f82ed

Prepare for new SYSCALL

060d300

shargon added the blocked label Feb 3, 2020

This was referenced Feb 4, 2020

Fix NEP5 test neo-project/neo-node#539

Merged

Add nullable checks neo-project/neo-vm#288

Closed

Add FeaturesAttribute

68e3c98

superboyiii reviewed Feb 5, 2020

View reviewed changes

templates/Template.NEP5.CSharp/NEP5.cs Show resolved Hide resolved

post build SC compilation

6aef026

superboyiii reviewed Feb 6, 2020

View reviewed changes

templates/Template.NEP5.CSharp/NEP5.Admin.cs Outdated Show resolved Hide resolved

doubiliu reviewed Feb 9, 2020

View reviewed changes

templates/Template.NEP5.CSharp/NEP5.Methods.cs Outdated Show resolved Hide resolved

superboyiii reviewed Feb 24, 2020

View reviewed changes

templates/Template.NEP5.CSharp/NEP5.Crowdsale.cs Outdated Show resolved Hide resolved

shargon and others added 3 commits February 24, 2020 12:35

Merge branch 'master' into nep5-template

c9be37c

Merge branch 'master' into nep5-template

c943c0c

revert GetCurrentTransaction

ff09479

shargon reviewed Mar 16, 2020

View reviewed changes

vncoelho reviewed Mar 17, 2020

View reviewed changes

lightszero suggested changes Mar 17, 2020

View reviewed changes

templates/Template.NEP5.CSharp/NEP5.cs Outdated Show resolved Hide resolved

shargon added neo3-preview-2 and removed blocked labels Mar 17, 2020

Merge branch 'master' into nep5-template

b49bc56

shargon dismissed stale reviews from Tommo-L and superboyiii via b49bc56 March 17, 2020 07:48

belane added 2 commits March 17, 2020 14:10

shargon improvements

e97f9e2

li optimizations

5c77b06

more changes

1362bb6

superboyiii mentioned this pull request Mar 19, 2020

An Issue for stringArray in smart contract when compile #211

Closed

belane and others added 2 commits March 19, 2020 13:00

Merge branch 'master' into nep5-template

dda5ede

add 214

c139760

Merge branch 'master' into nep5-template

4897e24

lightszero requested review from Tommo-L, lightszero, shargon and superboyiii March 20, 2020 08:31

lightszero approved these changes Mar 20, 2020

View reviewed changes

shargon approved these changes Mar 20, 2020

View reviewed changes

Tommo-L approved these changes Mar 21, 2020

View reviewed changes

lightszero merged commit 595e898 into neo-project:master Mar 22, 2020

Tommo-L mentioned this pull request Apr 8, 2020

Create NEP-5 template for Neo3 #152

Closed

9 tasks

Conversation

belane commented Feb 1, 2020

Uh oh!

shargon commented Feb 3, 2020

Uh oh!

superboyiii commented Feb 3, 2020

Uh oh!

superboyiii commented Feb 4, 2020

Uh oh!

shargon commented Feb 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doubiliu commented Feb 4, 2020

Uh oh!

Uh oh!

erikzhang commented Feb 5, 2020

Uh oh!

superboyiii commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shargon commented Feb 5, 2020

Uh oh!

superboyiii commented Feb 5, 2020

Uh oh!

shargon commented Feb 5, 2020

Uh oh!

superboyiii commented Feb 5, 2020

Uh oh!

belane commented Feb 5, 2020

Uh oh!

superboyiii commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

doubiliu commented Feb 9, 2020

Uh oh!

Uh oh!

Uh oh!

shargon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shargon Mar 16, 2020

Choose a reason for hiding this comment

Uh oh!

Tommo-L Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

belane Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

shargon Mar 16, 2020

Choose a reason for hiding this comment

Uh oh!

vncoelho Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

Tommo-L Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

belane Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

vncoelho left a comment

Choose a reason for hiding this comment

Uh oh!

lightszero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nicolegys commented Mar 18, 2020

Uh oh!

erikzhang commented Mar 18, 2020

Uh oh!

shargon commented Feb 4, 2020 •

edited

Loading

superboyiii commented Feb 5, 2020 •

edited

Loading

superboyiii commented Feb 6, 2020 •

edited

Loading

Tommo-L Mar 17, 2020 •

edited

Loading