Skip to content

Update dev-pack with last neo changes#146

Merged
shargon merged 20 commits intoneo-project:masterfrom
shargon:update-neo
Dec 9, 2019
Merged

Update dev-pack with last neo changes#146
shargon merged 20 commits intoneo-project:masterfrom
shargon:update-neo

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Dec 5, 2019 •
edited
Loading

erikzhang
erikzhang reviewed Dec 5, 2019
View reviewed changes
@erikzhang
Copy link
Copy Markdown
Member

erikzhang commented Dec 5, 2019 •
edited
Loading

Need to fix Travis too. Or do we move to Github Actions directly?

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Dec 5, 2019

@erikzhang Please, Could you take a look to neo-project/neo#1330 ?

shargon and others added 3 commits December 5, 2019 13:14
@shargon @erikzhang
Update tests/Neo.SmartContract.Framework.UnitTests/Neo.SmartContract.…
29003b9 
…Framework.UnitTests.csproj

Co-Authored-By: Erik Zhang <erik@neo.org>
@shargon @erikzhang
Update tests/Neo.Compiler.MSIL.UnitTests/Neo.Compiler.MSIL.UnitTests.…
8fcc2d8 
…csproj

Co-Authored-By: Erik Zhang <erik@neo.org>
@shargon @erikzhang
Update src/Neo.Compiler.MSIL/Neo.Compiler.MSIL.csproj
7b91507 
Co-Authored-By: Erik Zhang <erik@neo.org>
@shargon
Copy link
Copy Markdown
Member Author

shargon commented Dec 5, 2019 •
edited
Loading

Need to fix Travis too. Or do we move to Github Actions directly?

I think that we should move to github actions directly. What do you prefer?

@shargon shargon mentioned this pull request Dec 5, 2019
Merged
devhawk
devhawk reviewed Dec 5, 2019
View reviewed changes
src/Neo.Compiler.MSIL/Neo.Compiler.MSIL.csproj
<Version>2.4.1</Version>
<Authors>The Neo Project</Authors>
<TargetFrameworks>netcoreapp2.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks>netcoreapp3.1;netstandard2.1</TargetFrameworks>
Copy link
Copy Markdown
Contributor

@devhawk devhawk Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we supporting netstandard2.1 here. This is a CLI tool, it should just have the single 3.1 target framework

Copy link
Copy Markdown
Member

@erikzhang erikzhang Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it means that it is a library too.

Copy link
Copy Markdown
Contributor

@devhawk devhawk Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need it to be a library too?

Copy link
Copy Markdown
Member

@erikzhang erikzhang Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/neo-project/neo-compiler/pull/147#issue-252914432

This was the PR that turned neon into a library at the time. Maybe some developers have such a need. I do not know.

devhawk
devhawk reviewed Dec 5, 2019
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d3d00e2). Click here to learn what that means.
The diff coverage is 15.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #146   +/-   ##
=========================================
  Coverage          ?   40.82%           
=========================================
  Files             ?       42           
  Lines             ?     4561           
  Branches          ?        0           
=========================================
  Hits              ?     1862           
  Misses            ?     2699           
  Partials          ?        0
Impacted Files Coverage Δ
tests/Neo.Compiler.MSIL.UnitTests/UnitTest1.cs 0% <ø> (ø)
.../Neo.Compiler.MSIL.UnitTests/UnitTest_StaticVar.cs 0% <ø> (ø)
...ts/Neo.Compiler.MSIL.UnitTests/UnitTest_Appcall.cs 0% <ø> (ø)
...sts/Neo.Compiler.MSIL.UnitTests/UnitTest_Switch.cs 0% <ø> (ø)
...Compiler.MSIL.UnitTests/UnitTest_AutoEntrypoint.cs 0% <0%> (ø)
...SIL.UnitTests/TestClasses/Contract_shift_bigint.cs 0% <0%> (ø)
...ests/Neo.Compiler.MSIL.UnitTests/UnitTest_Shift.cs 0% <0%> (ø)
...piler.MSIL.UnitTests/TestClasses/Contract_shift.cs 0% <0%> (ø)
tests/Neo.Compiler.MSIL.UnitTests/UnitTest_NULL.cs 0% <0%> (ø)
...Neo.Compiler.MSIL.UnitTests/Utils/TestDataCache.cs 32% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d00e2...60de122. Read the comment docs.

shargon
shargon commented Dec 6, 2019
View reviewed changes
tests/Neo.Compiler.MSIL.UnitTests/UnitTest_Shift.cs
var result = testengine.ExecuteTestCaseStandard("testfunc");
ApplicationEngine.Notify -= method;

CollectionAssert.AreEqual(new BigInteger[] { 16, 17179869184, 4, 0 }, list);
Copy link
Copy Markdown
Member Author

@shargon shargon Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lightszero please take a look this, with int, we have a different result than BigInteger. it's this expected?

Copy link
Copy Markdown
Member

@erikzhang erikzhang Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only BigInteger in NeoVM, so currently it can only be handled like this.

Copy link
Copy Markdown
Member Author

@shargon shargon Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But integer result should be the same, because it should be converted to BigInteger. It's strange

Copy link
Copy Markdown
Member

@erikzhang erikzhang Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. We should treat the behavior of negative shifts as undefined and disallow it.

@shargon shargon merged commit ed93668 into neo-project:master Dec 9, 2019
@shargon shargon deleted the update-neo branch December 9, 2019 13:59
Jim8y pushed a commit that referenced this pull request Aug 3, 2025
@shargon
Update dev-pack with last neo changes (#146)
d392a43 
* Update references
* Update
* Clean file
* Update tests/Neo.SmartContract.Framework.UnitTests/Neo.SmartContract.Framework.UnitTests.csproj
Co-Authored-By: Erik Zhang <erik@neo.org>
* Update tests/Neo.Compiler.MSIL.UnitTests/Neo.Compiler.MSIL.UnitTests.csproj
Co-Authored-By: Erik Zhang <erik@neo.org>
* Update src/Neo.Compiler.MSIL/Neo.Compiler.MSIL.csproj
Co-Authored-By: Erik Zhang <erik@neo.org>
* Add Reference Counter
* Clean file
* Clean files
* Fix travis in order to know the error
* Update packages
* Update .travis.yml
* End changes
* dotnet-format
* Fix shift UT
* Update version
* Update framework
* Fix UT
Jim8y pushed a commit that referenced this pull request Aug 18, 2025
@shargon
Update dev-pack with last neo changes (#146)
beb3c37 
* Update references

* Update

* Clean file

* Update tests/Neo.SmartContract.Framework.UnitTests/Neo.SmartContract.Framework.UnitTests.csproj

Co-Authored-By: Erik Zhang <erik@neo.org>

* Update tests/Neo.Compiler.MSIL.UnitTests/Neo.Compiler.MSIL.UnitTests.csproj

Co-Authored-By: Erik Zhang <erik@neo.org>

* Update src/Neo.Compiler.MSIL/Neo.Compiler.MSIL.csproj

Co-Authored-By: Erik Zhang <erik@neo.org>

* Add Reference Counter

* Clean file

* Clean files

* Fix travis in order to know the error

* Update packages

* Update .travis.yml

* End changes

* dotnet-format

* Fix shift UT

* Update version

* Update framework

* Fix UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikzhang erikzhang erikzhang approved these changes

+1 more reviewer

@devhawk devhawk devhawk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shargon @erikzhang @devhawk