analyze write in nested try#1291
Merged
Hecate2 merged 3 commits intoneo-project:masterfrom Feb 7, 2025
Merged
Conversation
Contributor
Author
|
It is not checking writes in a catch nested in a try. Fixing. |
806f623 to
a9a35dc
Compare
a9a35dc to
b64741f
Compare
shargon
approved these changes
Feb 6, 2025
Jim8y
pushed a commit
that referenced
this pull request
Aug 3, 2025
* analyze write in nested try
* handle write in try{try catch{write}}
* add recursive call in tests
Jim8y
pushed a commit
that referenced
this pull request
Aug 18, 2025
* analyze write in nested try
* handle write in try{try catch{write}}
* add recursive call in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also considered unsafe, because the
Write()in the internal try may throw and be caught by the external try. Thus it is ambiguous whether the internalWrite()is reverted.