Add Console.WriteLine() in ConsensusService.Log()#974
Merged
Conversation
lock9
approved these changes
Jul 31, 2019
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
==========================================
+ Coverage 53.77% 53.77% +<.01%
==========================================
Files 194 194
Lines 13250 13251 +1
==========================================
+ Hits 7125 7126 +1
Misses 6125 6125
Continue to review full report at Codecov.
|
igormcoelho
approved these changes
Jul 31, 2019
vncoelho
reviewed
Jul 31, 2019
Member
vncoelho
left a comment
There was a problem hiding this comment.
Thus, the consensus log will be compulsory now, right?
That file registering we can set in a Logger Plugins:
lock (log_dictionary)
{
Directory.CreateDirectory(log_dictionary);
string path = Path.Combine(log_dictionary, $"{now:yyyy-MM-dd}.log");
File.AppendAllLines(path, new[] { line });
}
igormcoelho
reviewed
Jul 31, 2019
vncoelho
approved these changes
Jul 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.