Conversation
vncoelho
reviewed
Jul 31, 2019
Member
vncoelho
left a comment
There was a problem hiding this comment.
Bye bye, good friend. 💃
It has been good to see this as plugin, @erikzhang.
However, the Native contacts in outstanding in beauty and flexibility!
Member
|
closes #963 |
Member
|
closes neo-project/proposals#80 |
shargon
approved these changes
Jul 31, 2019
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
=========================================
Coverage ? 53.77%
=========================================
Files ? 194
Lines ? 13250
Branches ? 0
=========================================
Hits ? 7125
Misses ? 6125
Partials ? 0
Continue to review full report at Codecov.
|
igormcoelho
approved these changes
Jul 31, 2019
Contributor
igormcoelho
left a comment
There was a problem hiding this comment.
Very good, native policy now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #963