Skip to content

Allow to configure the capacity of the memory pool#948

Merged
lock9 merged 1 commit intoneo-project:masterfrom
shargon:configure-mem-pool
Jul 23, 2019
Merged

Allow to configure the capacity of the memory pool#948
lock9 merged 1 commit intoneo-project:masterfrom
shargon:configure-mem-pool

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Jul 23, 2019

Close #942

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 23, 2019

Codecov Report

Merging #948 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #948      +/-   ##
=========================================
+ Coverage   45.39%   45.4%   +<.01%     
=========================================
  Files         178     178              
  Lines       12662   12664       +2     
=========================================
+ Hits         5748    5750       +2     
  Misses       6914    6914
Impacted Files Coverage Δ
neo/Ledger/Blockchain.cs 37.5% <100%> (ø) ⬆️
neo/ProtocolSettings.cs 94.23% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d048805...ecb1e28. Read the comment docs.

@lock9
Copy link
Copy Markdown
Contributor

lock9 commented Jul 23, 2019

I've never done before, but since this is a very low impact issue, I will merge it. We need "rules" to know when "people like me" are allowed to merge things into the master branch.
So, I'm merging it, because:

  • Very low impact
  • Backward compatibility
  • Clear code
  • 3 'approvals' (shargon, vitor and me).

I'm sorry if I'm not supposed to do this without Erik approval, I just did because of the arguments mentioned above.
Thanks

@lock9 lock9 merged commit abda789 into neo-project:master Jul 23, 2019
@erikzhang erikzhang deleted the configure-mem-pool branch July 24, 2019 06:30
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configurable memory pool size

5 participants