Skip to content

Temporary fix for #922#936

Merged
shargon merged 1 commit intoneo-project:masterfrom
shargon:temp-fix
Jul 19, 2019
Merged

Temporary fix for #922#936
shargon merged 1 commit intoneo-project:masterfrom
shargon:temp-fix

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Jul 19, 2019

Please don't close #922 this is only for prevent travis errors until find a solution

@shargon shargon requested review from igormcoelho and lock9 July 19, 2019 08:16
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 19, 2019

Codecov Report

Merging #936 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #936      +/-   ##
=========================================
- Coverage   45.52%   45.5%   -0.02%     
=========================================
  Files         178     178              
  Lines       12635   12635              
=========================================
- Hits         5752    5750       -2     
- Misses       6883    6885       +2
Impacted Files Coverage Δ
neo/Network/P2P/Connection.cs 40% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d654c...deae08c. Read the comment docs.

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Jul 19, 2019

@neo-project/core Please review it asap

Copy link
Copy Markdown
Contributor

@lock9 lock9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shargon!

@shargon shargon merged commit 62766eb into neo-project:master Jul 19, 2019
@shargon shargon deleted the temp-fix branch July 19, 2019 16:28
Copy link
Copy Markdown
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good trick! Congrats

@igormcoelho igormcoelho mentioned this pull request Aug 29, 2019
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit test Fail when running UT_Culture and UT_RemoteNode together

5 participants