Merged
Conversation
Member
Author
|
I just double checked here and This minor size error was just here. |
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
- Coverage 45.52% 45.52% -0.01%
==========================================
Files 178 178
Lines 12636 12635 -1
==========================================
- Hits 5753 5752 -1
Misses 6883 6883
Continue to review full report at Codecov.
|
Contributor
|
Brother, this is supposed to be tested. Let me see if it passes. |
Contributor
|
I couldn't push into this branch.. strange... using FluentAssertions;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Neo.IO.Json;
using Neo.IO;
using Neo.Network.P2P.Payloads;
using System.IO;
using System.Text;
namespace Neo.UnitTests
{
[TestClass]
public class UT_ConsensusPayload
{
ConsensusPayload uut;
[TestInitialize]
public void TestSetup()
{
uut = new ConsensusPayload();
uut.Witness = new Witness();
uut.Witness.InvocationScript = new byte[0];
uut.Witness.VerificationScript = new byte[0];
uut.PrevHash = new UInt256();
uut.Data = new byte[0];
}
[TestMethod]
public void Test_Size()
{
uut.PrevHash.Size.Should().Be(32);
uut.Data.GetVarSize().Should().Be(1);
uut.Witness.Size.Should().Be(2); // +1 (implicit array)
uut.Size.Should().Be(4 + 32 + 4 + 2 + 1 + (1+2));
}
}
} |
shargon
approved these changes
Jul 18, 2019
Member
|
@vncoelho good eyes! |
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* Add files * update English files * 9/11 updates * updated * add index * update toc * updated toc links * translate * update formatting and links * update * update * fix links
Tommo-L
pushed a commit
to Tommo-L/neo
that referenced
this pull request
Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can you take a look if that proceeds? If yes, let's port to master2.x