Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
==========================================
+ Coverage 45.35% 45.52% +0.17%
==========================================
Files 178 178
Lines 12637 12636 -1
==========================================
+ Hits 5731 5753 +22
+ Misses 6906 6883 -23
Continue to review full report at Codecov.
|
Member
Author
|
One casting and one condition, because |
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
Tommo-L
pushed a commit
to Tommo-L/neo
that referenced
this pull request
Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, i don't like the
WriteBytesWithGroupingi understand the problem, but i think that we can (only on this class) read until the end of the stream, because always comes from a fixed buffer, so we don't need to write the length prefix.