Super speed multisg unit test#915
Merged
shargon merged 3 commits intoneo-project:masterfrom Jul 15, 2019
Merged
Conversation
vncoelho
reviewed
Jul 12, 2019
Member
vncoelho
left a comment
There was a problem hiding this comment.
Shargon, you are reverting the parallel creation of the wallets, right?
You found that a simple scrypt can be much faster, yes?
But why not process both in parallel?
Member
Author
|
because now is automatic |
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
=======================================
Coverage 45.16% 45.16%
=======================================
Files 178 178
Lines 12609 12609
=======================================
Hits 5695 5695
Misses 6914 6914Continue to review full report at Codecov.
|
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
Tommo-L
pushed a commit
to Tommo-L/neo
that referenced
this pull request
Jun 22, 2020
* Speed up * Remove async
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the best improve, from 6' to less than one second, for this kind of test, we don't need to test scrypt encryption so is better to test with the lowest values
My concern is that currently, travis spend a lot of time in unit testing