Conversation
|
We use the known hash for remove task here
But before the patch we get this
After the patch
So know hashes was not working as expected |
| public void FifoSetTest() | ||
| { | ||
| var a = UInt256.Zero; | ||
| var b = new UInt256(); |
There was a problem hiding this comment.
UInt256.Zero? Better than new UInt256(), no?
There was a problem hiding this comment.
I want the same data, with different objects
There was a problem hiding this comment.
Better to use two new UInt256(). Isn't it clearer? Or does it risk being the same object?
igormcoelho
left a comment
There was a problem hiding this comment.
Congratulations master
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
==========================================
+ Coverage 45.03% 45.16% +0.13%
==========================================
Files 178 178
Lines 12608 12608
==========================================
+ Hits 5678 5695 +17
+ Misses 6930 6913 -17
Continue to review full report at Codecov.
|
|
@shargon and @igormcoelho, please check this additional tests for fifo size. |
|
@vncoelho it passed now |
|
@shargon, I mean, this commit was wrong, it should not have passed.
Something weird is happening. |
|
Strange, I'll take a look. |
|
The test pass locally, please revert the changes, i will review the problem in few hours |
|
Shargon, the problem was that all tests were passing locally, even the wrong...ajajajjashauahheuah |
|
now pass, what is wrong? |
vncoelho
left a comment
There was a problem hiding this comment.
@shargon, it is very strange. I do not know why, but travis was confused here and passed a tested that failed.
I double checked everything locally and test are really failing.
Thus, I believe it is all correct.
I added some more couple of lines for ensuring Fifo max size verification.
neo.UnitTests/UT_FifoSet.cs
Outdated
|
|
||
| CollectionAssert.AreEqual(set.ToArray(), new UInt256[] { a, c }); | ||
|
|
||
| var d = new UInt256(new byte[32] { |
* Fix fifo set * More tests for FIFO size * Fixing indexes * Testing asset of different sets * Testing again * Update UT_FifoSet.cs * Update UT_FifoSet.cs * Tests for fifo max size * Fixing indentation
…ct#905 (cschuchardt88) Added icon to applications neo-project#908 (cschuchardt88)
…ct#905 (cschuchardt88) Added icon to applications neo-project#908 (cschuchardt88)
…ct#905 (cschuchardt88) Added icon to applications neo-project#908 (cschuchardt88)
Added blockchain show block/transactions/contracts commands neo-project#905 (csc…
Before the patch it return null values