Skip to content

Fix memory leak on TaskManager due to continuous growth of knownHashes (3.x)#871

Merged
vncoelho merged 1 commit intomasterfrom
fix-leak-knownhashes-TaskManager-3.0
Jun 26, 2019
Merged

Fix memory leak on TaskManager due to continuous growth of knownHashes (3.x)#871
vncoelho merged 1 commit intomasterfrom
fix-leak-knownhashes-TaskManager-3.0

Conversation

@vncoelho
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 26, 2019

Codecov Report

Merging #871 into master will increase coverage by 0.03%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   43.53%   43.56%   +0.03%     
==========================================
  Files         177      177              
  Lines       12566    12578      +12     
==========================================
+ Hits         5471     5480       +9     
- Misses       7095     7098       +3
Impacted Files Coverage Δ
neo/IO/Caching/FIFOSet.cs 22.85% <0%> (+22.85%) ⬆️
neo/Network/P2P/TaskManager.cs 19.44% <100%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0e895...79c7267. Read the comment docs.

@vncoelho
Copy link
Copy Markdown
Member Author

Even the coverage increased! :D ahueahuea

@vncoelho vncoelho merged commit d664be6 into master Jun 26, 2019
@vncoelho vncoelho deleted the fix-leak-knownhashes-TaskManager-3.0 branch June 26, 2019 15:35
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants