Skip to content

Clean memory#868

Merged
shargon merged 5 commits intoneo-project:masterfrom
shargon:clean-memory
Jun 26, 2019
Merged

Clean memory#868
shargon merged 5 commits intoneo-project:masterfrom
shargon:clean-memory

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Jun 26, 2019

Usually we clean the buffer where the private key was copied, as here

neo/neo/Wallets/KeyPair.cs

Line 51 in c64748e

Array.Clear(data, 0, data.Length);

But we forgot to clean these buffers.

@shargon shargon requested a review from erikzhang June 26, 2019 06:13
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 26, 2019

Codecov Report

Merging #868 into master will decrease coverage by <.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
- Coverage   43.57%   43.57%   -0.01%     
==========================================
  Files         177      177              
  Lines       12547    12552       +5     
==========================================
+ Hits         5467     5469       +2     
- Misses       7080     7083       +3
Impacted Files Coverage Δ
neo/Cryptography/Base58.cs 40% <0%> (-1.03%) ⬇️
neo/Cryptography/Helper.cs 26.22% <50%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bee40...b60c10c. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 26, 2019 •
edited
Loading

Codecov Report

Merging #868 into master will decrease coverage by 0.02%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
- Coverage   43.57%   43.54%   -0.03%     
==========================================
  Files         177      177              
  Lines       12547    12559      +12     
==========================================
+ Hits         5467     5469       +2     
- Misses       7080     7090      +10
Impacted Files Coverage Δ
neo/Wallets/Wallet.cs 48.47% <0%> (-1.18%) ⬇️
neo/Cryptography/Base58.cs 40% <0%> (-1.03%) ⬇️
neo/Cryptography/Helper.cs 26.22% <50%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bee40...7c369e9. Read the comment docs.

erikzhang
erikzhang reviewed Jun 26, 2019
View reviewed changes
@shargon shargon merged commit 897df9c into neo-project:master Jun 26, 2019
@shargon shargon deleted the clean-memory branch June 26, 2019 11:02
vncoelho
vncoelho reviewed Jun 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port to 2.x? @erikzhang @shargon @igormcoelho

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Dec 16, 2019

@vncoelho I think that we need to port this to 2x, do you want to do it?

Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@Celia18305
fix issue neo-project#868 (neo-project#876)
d47985d 
* fix issue neo-project#868

* Update claimgas.md
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
@shargon @Tommo-L
Clean memory (neo-project#868)
b79f2a9 
* Clean memory

* Other

* Other

* Update Wallet.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vncoelho vncoelho vncoelho left review comments

@erikzhang erikzhang erikzhang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shargon @codecov-io @erikzhang @vncoelho