Skip to content

Clean unused code#843

Merged
shargon merged 4 commits intoneo-project:masterfrom
shargon:summary-iterators
Jun 20, 2019
Merged

Clean unused code#843
shargon merged 4 commits intoneo-project:masterfrom
shargon:summary-iterators

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Jun 18, 2019 •
edited
Loading

Clean code

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 18, 2019 •
edited
Loading

Codecov Report

Merging #843 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   38.45%   38.45%   +<.01%     
==========================================
  Files         176      176              
  Lines       12475    12474       -1     
==========================================
  Hits         4797     4797              
+ Misses       7678     7677       -1
Impacted Files Coverage Δ
neo/Network/P2P/TaskSession.cs 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e844108...b138024. Read the comment docs.

vncoelho
vncoelho previously approved these changes Jun 18, 2019
View reviewed changes
erikzhang
erikzhang requested changes Jun 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this???

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Jun 19, 2019

Why we need two classes one for keys and other for values? these classes have the same logic

@erikzhang
Copy link
Copy Markdown
Member

erikzhang commented Jun 19, 2019

One returns Key() and another returns Value(). They are different.

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Jun 19, 2019

Ups xD thanks for your review :)

@shargon shargon closed this Jun 19, 2019
@shargon shargon force-pushed the summary-iterators branch from 87ec64e to 70bf2f5 Compare June 19, 2019 11:47
@shargon shargon reopened this Jun 19, 2019
@shargon shargon changed the title Reduce iterator classes Clean unused code Jun 19, 2019
@shargon shargon requested a review from erikzhang June 19, 2019 11:54
@erikzhang
Copy link
Copy Markdown
Member

erikzhang commented Jun 19, 2019

AssetDescriptor is used in neo-cli and neo-gui.

@shargon shargon merged commit 8bc36c3 into neo-project:master Jun 20, 2019
@shargon shargon deleted the summary-iterators branch June 20, 2019 07:28
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@Celia18305
sync up with neo-project#841 (neo-project#843)
ace72b5 
* sync up with neo-project#841

* Update cli.md
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
@shargon @Tommo-L
Clean unused code (neo-project#843)
b3acca0 
* Clean code

* Restore asset descriptor

* Clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikzhang erikzhang erikzhang approved these changes

@vncoelho vncoelho vncoelho left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shargon @codecov-io @erikzhang @vncoelho