Tests for ProtocolHandler Mailboxes (Neo 3.x)#809
Merged
igormcoelho merged 15 commits intoneo-project:masterfrom Jun 12, 2019
Merged
Tests for ProtocolHandler Mailboxes (Neo 3.x)#809igormcoelho merged 15 commits intoneo-project:masterfrom
igormcoelho merged 15 commits intoneo-project:masterfrom
Conversation
Contributor
Author
|
@vncoelho please apply your fix. |
Member
|
Brother, the fix was already applied. |
Member
|
These tests are not easy to be made! Nice templates, @igormcoelho. Great job. |
vncoelho
previously approved these changes
Jun 10, 2019
shargon
previously approved these changes
Jun 11, 2019
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
==========================================
+ Coverage 37.73% 37.85% +0.12%
==========================================
Files 176 176
Lines 12445 12445
==========================================
+ Hits 4696 4711 +15
+ Misses 7749 7734 -15
Continue to review full report at Codecov.
|
Member
|
Where is the tests :P ? I only see for |
igormcoelho
commented
Jun 12, 2019
| uut.IsHighPriority(Message.Create(MessageCommand.Transaction, s)).Should().Be(false); | ||
| uut.IsHighPriority(Message.Create(MessageCommand.Block, s)).Should().Be(false); | ||
| uut.IsHighPriority(Message.Create(MessageCommand.Consensus, s)).Should().Be(true); | ||
| uut.IsHighPriority(Message.Create(MessageCommand.Reject, s)).Should().Be(false); |
Contributor
Author
There was a problem hiding this comment.
Here the tests @shargon! hahaha
Focused on ProtocolHandler this time... Coverage increased a lot already, and on future we cover others ;)
Contributor
Author
|
Changed title now :P |
Contributor
Author
|
later I can try to.finish all. |
Contributor
Author
|
Dont accept yet |
vncoelho
approved these changes
Jun 12, 2019
Member
vncoelho
left a comment
There was a problem hiding this comment.
You can finish in another PR, Igor.
Contributor
Author
|
Ok then, I have to do for 2x as well.. it will help Ricardo. |
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* 部署和调用智能合约 wrong link cant goto 部署和调用智能合约 page cause of missing "zh-cn" * add sc migrate * format code * update
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* [EN] Sync up with neo-project#809 [EN] Sync up with neo-project#809 * minor update * fix some
Tommo-L
pushed a commit
to Tommo-L/neo
that referenced
this pull request
Jun 22, 2020
* tests for mailboxes on 3x * Fixing UT to MessageCommand * Fixing string * Explicit Byte * MessageCommand with random byte * space * testing all cases * Update UT_ConsensusServiceMailbox.cs * Update UT_RemoteNodeMailbox.cs * Update UT_TaskManagerMailbox.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic unit tests for Mailboxes.