Declaring timeout variables for connection#807
Merged
Conversation
shargon
approved these changes
Jun 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #807 +/- ##
=========================================
Coverage ? 37.73%
=========================================
Files ? 176
Lines ? 12444
Branches ? 0
=========================================
Hits ? 4696
Misses ? 7748
Partials ? 0
Continue to review full report at Codecov.
|
Member
|
Why not use |
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
Tommo-L
pushed a commit
to Tommo-L/neo
that referenced
this pull request
Jun 22, 2020
* Declaring timeout variables for connection * Improving comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are starting an effort for cleaning and improving the P2P classes.
@erikzhang, it is not related to this PR, but the
ack = false;happens inSendMessage(Message message)function of theRemoteNode.cs.After that, an
OnAck()event is needed for returning it totrueand enabling anothersendmessage. Can this be improved?