Fix accepting own prepare request. #596
Merged
erikzhang merged 2 commits intoconsensus/improved_dbftfrom Feb 21, 2019
Merged
Conversation
…equest() already have always verified the consensus state.
Merged
Contributor
Author
|
After this change, receiving testing Primary receiving its own change view is working as expected. |
This was referenced Feb 20, 2019
erikzhang
approved these changes
Feb 21, 2019
erikzhang
pushed a commit
that referenced
this pull request
Mar 3, 2019
* Add commit phase to consensus algorithm (#534) * Add commit phase to consensus algorithm * fix tests * Prevent repeated sending of `Commit` messages * RPC call gettransactionheight (#541) * getrawtransactionheight Nowadays two calls are need to get a transaction height, `getrawtransaction` with `verbose` and then use the `blockhash`. Other option is to use `confirmations`, but it can be misleading. * Minnor fix * Shargon's tip * modified * Allow to use the wallet inside a RPC plugin (#536) * Clean code * Clean code * Minor fix on mempoolVerified * Add MemoryPool Unit tests. Fix bug on initital start of Persisting the Genesis block. * Prevent `ConsensusService` from receiving messages before starting (#573) * Prevent `ConsensusService` from receiving messages before starting * fixed tests - calling OnStart now * Consensus recovery log (#572) * Pass store to `ConsensusService` * Implement `ISerializable` in `ConsensusContext` * Start from recovery log * Fix unit tests due to constructor taking the store. * Add unit tests for serializing and deserializing the consensus context. * Combine `ConsensusContext.ChangeView()` and `ConsensusContext.Reset()` * Add `PreparationHash` field to `PrepareResponse` to prevent replay attacks from malicious primary (#576) * Fixed a problem where `PrepareResponse.PreparationHash` was not assigned. * Load context from store only when height matches * Recover nodes requesting ChangeView when possible (#579) * Fixes bug in `OnPrepareRequestReceived()` * Send `RecoveryMessage` only when `message.NewViewNumber <= context.ViewNumber` * Fix and optimize view changing (#590) * Allow to ignore the recovery logs * Add `isRecovering` (#594) * Fix accepting own prepare request (#596) * Pick some changes from #575. * Fixes `Prefixes` * Restore transactions from saved consensus context (#598) * Refactoring * AggressiveInlining (#606) * Reset Block reference when consensus context is initialized after block persist. (#608) * Change `ConsensusPayload` for compatibility (#609)
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* 2.8.0 exchange doc * Update v2.7.6.md (neo-project#595) Add xfs setting for sever.
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* sync up recent changes related to neo-project#587, neo-project#590, neo-project#594, neo-project#596, neo-project#597, neo-project#602 * minor updates minor updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing showed the primary was still changing view too soon when recovering it's own prepare request after the merge of #594
The check in
VerifyRequest()needed to either check additionally for whether the request was sent in addition to being received or just have these checks removed. I checked all places this is called, and it is just fromAddTransaction, and all places that callAddTransactionalready have verified that either theRequestSentor theRequestReceivedflags are sent. So the check can just be removed inside ofVerifyRequest().