Conversation
jsolman
reviewed
Dec 6, 2018
Contributor
jsolman
left a comment
There was a problem hiding this comment.
Actually maybe we need a way to have the idle message indicate it doesn’t want another one for at least x amount of time and then a timer will be able to send one of it is idle still after that time.
jsolman
approved these changes
Dec 6, 2018
Contributor
jsolman
left a comment
There was a problem hiding this comment.
Makes sense after looking at it more carefully. I’ll adjust my PR to re-enqueue the idle message again. The way I have it currently it will only do something after another message is handled.
rodoufu
pushed a commit
to rodoufu/neo
that referenced
this pull request
Mar 5, 2019
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.